xfs
[Top] [All Lists]

Re: 2.4.19 with split patches fails to build quota on powerpc

To: Nathan Scott <nathans@xxxxxxx>
Subject: Re: 2.4.19 with split patches fails to build quota on powerpc
From: Jan Kara <jack@xxxxxxx>
Date: Mon, 5 Aug 2002 16:01:36 +0200
Cc: Ethan Benson <erbenson@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Jan Kara <jack@xxxxxx>, linux-xfs@xxxxxxxxxxx
In-reply-to: <20020805082302.GG3410@frodo>
References: <20020803145056.A25690@xxxxxxxxxxxxxxx> <20020805082302.GG3410@frodo>
Sender: owner-linux-xfs@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
  Hello,
  
> Looks like this crept in with that 2.5 quota port, Christoph.
> On 2.5, L1_CACHE_SHIFT is declared for all architectures.  I
> guess we could go back to using HASHDEV(sb->s_dev?) for 2.4?
  Yes, that's right.
  
> A simple build fix, Ethan, would be to change dquot.c::hashfn
> so that it uses the HASHDEV macro again (similar to revision
> 1.48 of fs/dquot.c, except no dev parameter anymore so use
> sb->s_dev instead).  I'll wait to hear from Christoph &/ Jan
> before checking anything into the tree though.

                                                        Honza
                                                        


<Prev in Thread] Current Thread [Next in Thread>