Re: gcc 3.2

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Thu, Aug 29, 2002 at 08:41:31AM -0500, Steve Lord wrote:
> 
> On Thu, 2002-08-29 at 08:35, stefano sartini wrote:
> 
> > 
> > Compiling back with the 2.95.3 gcc gave no problem...
> > Is a compiler issue?
> 
> 
> Go to line 203 of page_buf_locking.c and replace the call to ffs
> with a call to generic_ffs.
> 
> Let me know if this fixes it and I will check it in to the tree.

Please don't check it in.  The following patch that went into 2.4.20-pre
should fix the root of the problem instead of the symptom:


--- linux-2.4.19-rc3-ac4/include/asm-i386/bitops.h      Mon Jul 29 21:12:34 2002
+++ linux/include/asm-i386/bitops.h     Mon Jul 29 21:38:44 2002
@@ -456,7 +456,7 @@ static __inline__ int ffs(int x)
        __asm__("bsfl %1,%0\n\t"
                "jnz 1f\n\t"
                "movl $-1,%0\n"
-               "1:" : "=r" (r) : "g" (x));
+               "1:" : "=r" (r) : "rm" (x));
        return r+1;
 }