xfs
[Top] [All Lists]

acl_extended_file() still returning somewhat innaccurate info

To: linux-xfs@xxxxxxxxxxx
Subject: acl_extended_file() still returning somewhat innaccurate info
From: Ethan Benson <erbenson@xxxxxxxxxx>
Date: Sat, 10 Aug 2002 23:45:17 -0800
Mail-copies-to: nobody
Mail-followup-to: linux-xfs@xxxxxxxxxxx
Sender: owner-linux-xfs@xxxxxxxxxxx
User-agent: Mutt/1.2.5i
when a directory has a simple default acl to say ensure that the
primary group always has write permission, files created under that
directory still get a system.posix_acl_access attribute (even though
its completly unecessary as only the standard permission bits are
used). this causes acl_extended_file() to claim a file has an extended
acl when in fact it does not:

eb@ash ~$ mkdir defacl
eb@ash ~$ setfacl -dm u::rwx,g::rwx,o::r-x defacl
eb@ash ~$ getfacl defacl/
# file: defacl
# owner: eb
# group: eb
user::rwx
group::r-x
other::r-x
default:user::rwx
default:group::rwx
default:other::r-x

eb@ash ~$ touch defacl/foo
eb@ash ~$ getfacl defacl/foo
# file: defacl/foo
# owner: eb
# group: eb
user::rw-
group::rw-
other::r--

eb@ash ~$ getfacl --skip-base defacl/foo
eb@ash ~$ ls -l defacl/foo
-rw-rw-r--+   1 eb       eb              0 Aug 10 23:40 defacl/foo
eb@ash ~$ getfattr -m . defacl/foo
# file: defacl/foo
system.posix_acl_access

eb@ash ~$

ideally XFS would not unecessarily create this attribute when the
standard permission bits are sufficient, this would perhaps save some
small ammount of disk space as well.  failing that is it possible to
fix acl_extended_file() to notice and ignore superflurious
posix_acl_access attributes that are doing nothing but duplicating the
standard mode bits?

-- 
Ethan Benson
http://www.alaska.net/~erbenson/

Attachment: pgp63qhqJvuaI.pgp
Description: PGP signature

<Prev in Thread] Current Thread [Next in Thread>