xfs
[Top] [All Lists]

Re: [PATCH] fix qsort breakage

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] fix qsort breakage
From: Keith Owens <kaos@xxxxxxx>
Date: Tue, 09 Jul 2002 17:43:47 +1000
Cc: Andrew Morton <akpm@xxxxxxxxxx>, linux-xfs@xxxxxxxxxxx
In-reply-to: Your message of "Tue, 09 Jul 2002 08:11:49 +0100." <20020709081149.A3621@infradead.org>
Sender: owner-linux-xfs@xxxxxxxxxxx
On Tue, 9 Jul 2002 08:11:49 +0100, 
Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>On Tue, Jul 02, 2002 at 02:33:52PM -0700, Andrew Morton wrote:
>> (It'd be nice to stick that qsort in lib/qsort.c, rather than making
>> it XFS-private, btw).
>
>*nod* - the problem is that this would make the core changes of XFS bigger
>again.  Maybe you find a use for it in 2.5 and can send it to Linus ;)

Kching!  Init and exit sections break the assumptions that exception
tables are sorted.  The thread started in
http://marc.theaimsgroup.com/?l=linux-kernel&m=101912337804026&w=2
and ended with agreement that the fix was needed but it should use a
better sort routine.  I got sidetracked and never did the better sort
routine.  Sounds like a good use for qsort.


<Prev in Thread] Current Thread [Next in Thread>