xfs
[Top] [All Lists]

TAKE - Fix log recovery error returns

Subject: TAKE - Fix log recovery error returns
From: Eric Sandeen <sandeen@xxxxxxx>
Date: Wed, 8 May 2002 13:58:43 -0500
Sender: owner-linux-xfs@xxxxxxxxxxx
In general, 2 changes here:

1) many places returned "-ENOMEM" but within XFS, this should be
(+)ENOMEM.

2) xlog_find_verify_cycle was modified in 9/2000, and along with the
modification came some possible errors that could be returned from the
function.  Callers don't expect errors, and would interpret them as
block numbers :(.  This function now returns any error, and the 
block number is passed in as a pointer, making it easy to distinguish
between errors and block numbers. :-)

I think the latter case _might_ be where the bigstorage people are
having trouble.

Date:  Wed May  8 11:56:56 PDT 2002
Workarea:  
stout.americas.sgi.com:/localhome/src/sandeen/2.4.x-xfs/workarea-alwaysclean

The following file(s) were checked into:
  bonnie.engr.sgi.com:/isms/slinx/2.4.x-xfs


Modid:  xfs-cmds:slinx:118599a
cmd/xfsprogs/doc/CHANGES - 1.64
        - Document error return fixes, also an older mkfs fix

cmd/xfsprogs/libxlog/xfs_log_recover.c - 1.5
        - Return errors from xlog_find_verify_cycle in such a way
          that we can distinguish them from normal returns.
          Fix sign of -ENOMEM returns; should be (+) returns.




Modid:  2.4.x-xfs:slinx:118599b
linux/fs/xfs/xfs_log_recover.c - 1.226
        - Return errors from xlog_find_verify_cycle in such a way
          that we can distinguish them from normal returns.
          Fix sign of -ENOMEM returns; should be (+) returns.



<Prev in Thread] Current Thread [Next in Thread>