xfs
[Top] [All Lists]

TAKE - Remove dead vnode code

Subject: TAKE - Remove dead vnode code
From: Eric Sandeen <sandeen@xxxxxxx>
Date: Tue, 28 May 2002 17:31:52 -0500
Sender: owner-linux-xfs@xxxxxxxxxxx
Date:  Tue May 28 15:30:45 PDT 2002
Workarea:  
stout.americas.sgi.com:/localhome/src/sandeen/2.4.x-xfs/workarea-testing


There were several vnode flags (v_flag) that were either set but never
tested, or vice versa, remove those.  Also some extra checking
in the remove, rmdir, rename paths that was duplicating work that
the Linux VFS layer already does.


The following file(s) were checked into:
  bonnie.engr.sgi.com:/isms/slinx/2.4.x-xfs


Modid:  2.4.x-xfs:slinx:120312a
linux/fs/xfs/xfs_vnodeops.c - 1.527
        - Remove checks for VISSWAP, it's never set.
          Remove xfs_pre_rename, xfs_pre_rmdir, xfs_pre_remove, 
          these either checked flags that are never set, or duplicated
          standard Linux VFS checks already in place.

linux/fs/xfs/xfs_dmapi.c - 1.53
linux/fs/xfs/xfs_vfsops.c - 1.347
        - Remove checks for VISSWAP, it's never set.

linux/fs/xfs/xfs_dfrag.c - 1.29
        - Remove checks for VISSWAP, it's never set.
          Don't set VREMAPPING, nobody ever checks it.

linux/fs/xfs/xfs_mount.c - 1.283
        - Don't set VROOT, nobody ever checks it.

linux/fs/xfs/xfs_inode.c - 1.338
        - Don't set VENF_LOCKING, nobody ever checks it.

linux/fs/xfs/xfs_utils.c - 1.43
linux/fs/xfs/xfs_utils.h - 1.15
linux/fs/xfs/xfs_rename.c - 1.33
        - Remove xfs_pre_rename, xfs_pre_rmdir, xfs_pre_remove, 
          these either checked flags that are never set, or duplicated
          standard Linux VFS checks already in place.

linux/fs/xfs/linux/xfs_vnode.c - 1.76
        - Remove VLOCK and VLOCKHOLD flags, never used.

linux/fs/xfs/linux/xfs_super.c - 1.171
        - Remove cvp, we set it but never use it.



<Prev in Thread] Current Thread [Next in Thread>
  • TAKE - Remove dead vnode code, Eric Sandeen <=