xfs
[Top] [All Lists]

Re: default acl inheritence bug

To: Timothy Shimmin <tes@xxxxxxxxxxxxxxxxxxxxxxx>
Subject: Re: default acl inheritence bug
From: Ethan Benson <erbenson@xxxxxxxxxx>
Date: Sun, 28 Apr 2002 20:04:58 -0800
Cc: Andreas Gruenbacher <ag@xxxxxxxxxxx>, linux-xfs@xxxxxxxxxxx
In-reply-to: <20020429132402.N144037@xxxxxxxxxxxxxxxxxxxxxxx>; from tes@xxxxxxxxxxxxxxxxxxxxxxx on Mon, Apr 29, 2002 at 01:24:02PM +1000
Mail-copies-to: nobody
Mail-followup-to: Timothy Shimmin <tes@xxxxxxxxxxxxxxxxxxxxxxx>, Andreas Gruenbacher <ag@xxxxxxxxxxx>, linux-xfs@xxxxxxxxxxx
References: <20020417011517.G20630@xxxxxxxxxxxxxxx> <Pine.LNX.4.33.0204251344580.23243-100000@xxxxxxxxxxxxxxxx> <20020426041111.F21791@xxxxxxxxxxxxxxx> <"from erbenson"@alaska.net> <20020429132402.N144037@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: owner-linux-xfs@xxxxxxxxxxx
User-agent: Mutt/1.2.5i
On Mon, Apr 29, 2002 at 01:24:02PM +1000, Timothy Shimmin wrote:
> > >     tes@sagan /mnt/xfs0/testdir/test1> getfacl .
> > >     # file: .
> > >     # owner: tes
> > >     # group: tes
> > >     user::rwx
> > >     group::rwx
> > >     other::r-x
> > >     default:user::rwx
> > >     default:user:tes:r--
> > >     default:group::rwx
> > >     default:mask::rwx
> > >     default:other::r-x
> > > 
> > >     tes@sagan /mnt/xfs0/testdir/test1> touch foo
> > >     tes@sagan /mnt/xfs0/testdir/test1> getfacl foo
> > >     # file: foo
> > >     # owner: tes
> > >     # group: tes
> > >     user::rw-
> > >     user:tes:r--
> > >     group::rwx                      #effective:rw-
> > >     mask::rw-
> > >     other::r--
> 
> > im on 2.4.18 split patches, so perhaps this is already fixed, 
> Perhaps.
> (But I've never seen this as a bug before - so there were
>  no intentional fixes AFAIK.)
> 

your test is wrong, thats the problem, if you create a directory with
your default acl then user tes won't have execute permission to it:

eb@dogbert /home/eb/test$ getfacl .
# file: .
# owner: eb
# group: eb
user::rwx
group::r-x
other::r-x
default:user::rwx
default:user:bin:r--
default:group::r-x
default:mask::r-x
default:other::r-x

eb@dogbert /home/eb/test$ mkdir foo
eb@dogbert /home/eb/test$ getfacl foo
# file: foo
# owner: eb
# group: eb
user::rwx
user:bin:r--
group::r-x
mask::r-x
other::r-x
default:user::rwx
default:user:bin:r--
default:group::r-x
default:mask::r-x
default:other::r-x

so the obvious solution to this is set r-x for user:tes on the default
acl, but that breaks file creation.  one way or another you get broken
behavior, if acls would follow standard unix behavior of files getting
666 masked by default and directories get 777 masked it would work.

or perhaps not having separate default acls for files/dirs is just
broken, which is the conclusion im coming to, at least with the
current broken behavior.


-- 
Ethan Benson
http://www.alaska.net/~erbenson/

Attachment: pgp0DcgWBuPhk.pgp
Description: PGP signature

<Prev in Thread] Current Thread [Next in Thread>