xfs
[Top] [All Lists]

Re: Can't build kernal with DMAPI as a module in 2.4 CVS

To: Dean Roehrich <roehrich@xxxxxxx>
Subject: Re: Can't build kernal with DMAPI as a module in 2.4 CVS
From: Keith Owens <kaos@xxxxxxx>
Date: Fri, 19 Apr 2002 14:12:43 +1000
Cc: matthew@xxxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxx
In-reply-to: Your message of "Thu, 18 Apr 2002 22:12:47 EST." <200204190312.WAA04315@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: owner-linux-xfs@xxxxxxxxxxx
On Thu, 18 Apr 2002 22:12:47 -0500, 
Dean Roehrich <roehrich@xxxxxxx> wrote:
>I believe your change will limit DMAPI to [yn] if XFS is 'y', but does it
>really limit DMAPI to [mn] if XFS is 'm'?  (I don't have convenient access to
>a build machine tonight.)
>> if [ "$CONFIG_XFS_FS" != "n" ]; then
>>+    # Current DMAPI code has calls from XFS to DMAPI.  This requires that
>>+    # DMAPI be built in if selected and XFS is built in.  Valid combinations
>>+    #   XFS=n, DMAPI=n
>>+    #   XFS=y, DMAPI=[yn]
>>+    #   XFS=m, DMAPI=[mn]
>>     dep_tristate '  Enable XFS DMAPI' CONFIG_XFS_DMAPI $CONFIG_XFS_FS
>>     if [ "$CONFIG_XFS_DMAPI" != "n" ]; then
>>+       if [ "$CONFIG_XFS_FS" = "y" ]; then
>>+          define_tristate CONFIG_XFS_DMAPI y
>>+       fi      
>>        define_bool CONFIG_HAVE_XFS_DMAPI y
>>     fi

dep_tristate enforces CONFIG_XFS_FS=m -> CONFIG_XFS_DMAPI=[mn]


<Prev in Thread] Current Thread [Next in Thread>