>From: Keith Owens <kaos@xxxxxxx>
>On Thu, 18 Apr 2002 22:12:47 -0500,
>Dean Roehrich <roehrich@xxxxxxx> wrote:
>>I believe your change will limit DMAPI to [yn] if XFS is 'y', but does it
>>really limit DMAPI to [mn] if XFS is 'm'? (I don't have convenient access to
>>a build machine tonight.)
>>> if [ "$CONFIG_XFS_FS" != "n" ]; then
>>>+ # Current DMAPI code has calls from XFS to DMAPI. This requires that
>>>+ # DMAPI be built in if selected and XFS is built in. Valid combination
>s
>>>+ # XFS=n, DMAPI=n
>>>+ # XFS=y, DMAPI=[yn]
>>>+ # XFS=m, DMAPI=[mn]
>>> dep_tristate ' Enable XFS DMAPI' CONFIG_XFS_DMAPI $CONFIG_XFS_FS
>>> if [ "$CONFIG_XFS_DMAPI" != "n" ]; then
>>>+ if [ "$CONFIG_XFS_FS" = "y" ]; then
>>>+ define_tristate CONFIG_XFS_DMAPI y
>>>+ fi
>>> define_bool CONFIG_HAVE_XFS_DMAPI y
>>> fi
>
>dep_tristate enforces CONFIG_XFS_FS=m -> CONFIG_XFS_DMAPI=[mn]
Ah, but apparently it doesn't enforce the other way. XFS=y -> DMAPI=[yn].
Why would that be?
Dean
|