xfs
[Top] [All Lists]

RE: oops umounting full LVM snapshots

To: "FORRESTER,JUSTIN ""(HP-Loveland,ex1)" <justin_forrester@xxxxxx>
Subject: RE: oops umounting full LVM snapshots
From: Eric Sandeen <sandeen@xxxxxxx>
Date: 01 Mar 2002 17:10:57 -0600
Cc: "'Steve Lord'" <lord@xxxxxxx>, "'Xfs Mailing \"List (E-mail)'\"" <linux-xfs@xxxxxxxxxxx>
In-reply-to: <Pine.LNX.4.33.0202282101270.20457-100000@lvjf4965.fc.hp.com>
References: <Pine.LNX.4.33.0202282101270.20457-100000@lvjf4965.fc.hp.com>
Sender: owner-linux-xfs@xxxxxxxxxxx
The issue here is changing the quota state on a read-only device - i.e.
if quota's on in the superblock but mounted w/o quota, or vice versa.
We can't do this on a read-only device because this will require a
transaction.

It's not the VFS flags we're worried about, it's the whether the device
itself is read-only (as in the LVM snapshot case).

So if we're trying to change quota state on a read-only device, we
should fail.

I have the basic code going to detect the situation, but I'm having
trouble erroring out of the mount path cleanly, now.  Each solution
brings new problems. :)

The quick fix for those of you experiencing this is to mount your
snapshots with the same quota options as the original filesystem.

-Eric


On Thu, 2002-02-28 at 22:18, FORRESTER,JUSTIN (HP-Loveland,ex1) wrote:
> 
> I was able to get rid of the problem with a simple hack to clear out the
> quota flags in the [in-core] sb if we're mounted ro.  The fs shutdown
> problem went away, as did the subsequent oops.  fyi.
> 
> Justin

-- 
Eric Sandeen      XFS for Linux     http://oss.sgi.com/projects/xfs
sandeen@xxxxxxx   SGI, Inc.


<Prev in Thread] Current Thread [Next in Thread>