xfs
[Top] [All Lists]

Re: attr_get() limited to 3061 bytes

To: "ZINKEVICIUS,MATT ""(HP-Loveland,ex1)" <matt_zinkevicius@xxxxxx>
Subject: Re: attr_get() limited to 3061 bytes
From: Eric Sandeen <sandeen@xxxxxxx>
Date: 15 Jan 2002 14:25:38 -0600
Cc: "'linux-xfs@xxxxxxxxxxx'" <linux-xfs@xxxxxxxxxxx>
In-reply-to: <F341E03C8ED6D311805E00902761278C07EFA873@xxxxxxxxxxxxxxx>
References: <F341E03C8ED6D311805E00902761278C07EFA873@xxxxxxxxxxxxxxx>
Sender: owner-linux-xfs@xxxxxxxxxxx
On Mon, 2002-01-14 at 15:47, ZINKEVICIUS,MATT (HP-Loveland,ex1) wrote:
> Howdy... More opportunities for printers :-)
> 
> The attr_get() call returns a zero filled buffer if the size value is
> greater than 3061 bytes.

Hm, perhaps this has something to do with the fact that we were reading
memory into the attribute data when we were setting the attribute, and
reading the data into memory when we were getting the attribute... which
is quite backwards!

See if this does the trick for you...


--- /usr/tmp/TmpDir.1648-0/linux/fs/xfs/xfs_buf.h       Tue Jan 15 14:22:53 2002
+++ linux/fs/xfs/xfs_buf.h      Tue Jan 15 14:10:10 2002
@@ -252,7 +252,7 @@
 
 #define xfs_biomove(pb, off, len, data, rw) \
            pagebuf_iomove((pb), (off), (len), (data), \
-               ((rw) == XFS_B_WRITE) ? PBRW_READ : PBRW_WRITE)
+               ((rw) == XFS_B_WRITE) ? PBRW_WRITE : PBRW_READ)
 
 #define xfs_biozero(pb, off, len) \
            pagebuf_iomove((pb), (off), (len), NULL, PBRW_ZERO)



-Eric

-- 
Eric Sandeen      XFS for Linux     http://oss.sgi.com/projects/xfs
sandeen@xxxxxxx   SGI, Inc.


<Prev in Thread] Current Thread [Next in Thread>