xfs
[Top] [All Lists]

TAKE - xfsdump inomap supprt_prune assertion fix

To: linux-xfs@xxxxxxxxxxx
Subject: TAKE - xfsdump inomap supprt_prune assertion fix
From: Timothy Shimmin <tes@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Fri, 11 Jan 2002 18:58:54 +1100 (EST)
Sender: owner-linux-xfs@xxxxxxxxxxx
Matteo,
this should stop the assertion failure in xfsdump:
  "xfsdump: inomap.c:858: supprt_prune: Assertion `state != 2' failed"
that you got.
I was able to reproduce this once 
by writing a script which did many file creations, rm's, mkdir's, rmdir's
while the dump was going on.
For the assertion to fire, one needed to have the inode# reused
durint the interval between building the inode map and pruning it.
The fix now updates the inodemap with the latest info and
does not abort :).
(If the inodemap get's out of date again, then it should just mean
 that the inode might not get dumped this time but will on next 
 incremental.)


--Tim

Date:  Thu Jan 10 23:51:08 PST 2002
Workarea:  snort.melbourne.sgi.com:/home/diskb/build4/tes/slinx-xfs
desc:  xfsdump inomap supprt_prune assertion fix

The following file(s) were checked into:
  bonnie.engr.sgi.com:/isms/slinx/2.4.x-xfs


Modid:  xfs-cmds:slinx:109430a
cmd/xfsdump/VERSION - 1.26
        - Update for xfsdump inomap supprt_prune assertion fix.

cmd/xfsdump/doc/CHANGES - 1.30
        - Update for xfsdump inomap supprt_prune assertion fix.

cmd/xfsdump/dump/inomap.c - 1.11
        - If inomap is obviously out of date during supprt_prune(), then
          don't cause an assertion failure, just update the inode map to
          the latest stat info.



<Prev in Thread] Current Thread [Next in Thread>