xfs
[Top] [All Lists]

Re: extended attributes support on powerpc

To: Ethan Benson <erbenson@xxxxxxxxxx>
Subject: Re: extended attributes support on powerpc
From: Keith Owens <kaos@xxxxxxx>
Date: Mon, 28 Jan 2002 13:24:26 +1100
Cc: linux-xfs@xxxxxxxxxxx
In-reply-to: Your message of "Sun, 27 Jan 2002 17:04:35 -0900." <20020127170434.K14742@plato.local.lan>
Sender: owner-linux-xfs@xxxxxxxxxxx
On Sun, 27 Jan 2002 17:04:35 -0900, 
Ethan Benson <erbenson@xxxxxxxxxx> wrote:
>extended attributes (and thus acls) do not appear to be supported on
>powerpc, as far as i can tell this is because the acl-xattr patches do
>not add the syscall and unistd.h defines for the powerpc arch (only
>i386 and ia64).  is there any more to it then that? and if not how
>difficult is it to do so?  (it looks trivial, but a kernel hacker i am
>not...)

It should be that simple.  Find 3 unused syscall numbers in
sys_call_table in arch/ppc/kernel/misc.S, in 2.4.17 the next 3 are
208-210.  Add these lines after sys_gettid, adjusting to fit current
ppc syscall usage.

#ifdef CONFIG_HAVE_ATTRCTL
        .long SYMBOL_NAME(sys_attrctl)
        .long SYMBOL_NAME(sys_acl_get)
        .long SYMBOL_NAME(sys_acl_set)          /* 210 */
#else
        .long SYMBOL_NAME(sys_ni_syscall)
        .long SYMBOL_NAME(sys_ni_syscall)
        .long SYMBOL_NAME(sys_ni_syscall)       /* 210 */
#endif  /* CONFIG_HAVE_ATTRCTL */

Add these to include/asm-ppc/unistd.h, adjusting as required.

#define __NR__attrctl           208
#define __NR__acl_get           209
#define __NR__acl_set           210

>btw, somewhat related but i noticed that the -misc patch adds the
>syscall defines to ia64's unistd.h, but the -acl-extattr patch adds it
>to i386's any reason for this inconsistency? or a bug in the patch
>generation scripts?

Human error, I will fix it in the next patch set.


<Prev in Thread] Current Thread [Next in Thread>