Keith, I'd like your input on this, since you're the guru. :)
I took care of your(?) comment in the makefiles:
# This needs -I. because everything does #include <xfs.h> instead of "xfs.h".
# The code is wrong, local files should be included using "xfs.h", not <xfs.h>
# but I am not going to change every file at the moment.
and changed all the xfs #includes to local includes, but for some of the
files in fs/xfs/linux, we need to include files from fs/xfs. It looks a bit
ugly to do:
#include "../xfs.h"
Is there a better way?
-Eric
On Wed, 23 Jan 2002, Stephen Lord wrote:
> Keith Owens wrote:
>
> >On Wed, 23 Jan 2002 17:50:36 -0600,
> >Steve Lord <lord@xxxxxxx> wrote:
> >
> >>This makes xfs and spinlock debugging in the same kernel possible.
> >>linux/fs/xfs/Makefile - 1.133
> >>linux/fs/xfs/linux/Makefile - 1.47
> >> - Remove the explicit setting of -funsigned-char from the makefile
> >>
> >
> >fs/xfs_dmapi/Makefile still uses -funsigned-char. Deliberate? Also all
> >the fs/xfs*/Makefile.in files need to be changed to keep them in sync.
> >
> Woops, no, I was building dmapi, but I did not spot that one. I will take a
> look at removing it too, although it looks like the whole header
> file cleanup job still needs to happen in the dmapi code.
>
> Steve
>
>
>
>
>
|