xfs
[Top] [All Lists]

Re: QAsuite044 on devfs

To: ASANO Masahiro <masano@xxxxxxxxxxxxxx>
Subject: Re: QAsuite044 on devfs
From: Nathan Scott <nathans@xxxxxxx>
Date: Thu, 20 Dec 2001 20:10:54 +1100
Cc: linux-xfs@xxxxxxxxxxx
In-reply-to: <20011220171654N.masano@xxxxxxxxxxxxxx>; from masano@xxxxxxxxxxxxxx on Thu, Dec 20, 2001 at 05:16:54PM +0900
References: <20011220171654N.masano@xxxxxxxxxxxxxx>
Sender: owner-linux-xfs@xxxxxxxxxxx
User-agent: Mutt/1.2.5i
On Thu, Dec 20, 2001 at 05:16:54PM +0900, ASANO Masahiro wrote:
> Hi,
> 
> A "kernel NULL pointer dereference" occurred at devfs_open() when I
> executed QA suite 044 on my box with devfs. It handled an inode whose
> i_bdev was NULL.
> blkdev_put() had been changed to call bdput() from its inside at
> Linux-2.4.10, but it seems that linvfs_release_buftarg() dose not cope
> with it.
> 
> If I can be of further assistance, please let me know.

Sounds like you've pretty much solved the problem already!
Based on your assessment above, does this patch help at all?

--- linux/fs/xfs/linux/xfs_super.c.orig Thu Dec 20 09:56:07 2001
+++ linux/fs/xfs/linux/xfs_super.c      Thu Dec 20 09:56:20 2001
@@ -383,7 +383,6 @@
        }
        if (bdev) {
                blkdev_put(bdev, BDEV_FS);
-               bdput(bdev);
        }
 }


thanks.

-- 
Nathan


<Prev in Thread] Current Thread [Next in Thread>