xfs
[Top] [All Lists]

Re: reenabling quota after xfs_repair

To: Robert Sander <robert.sander@xxxxxxxxxxxxxxx>, Chmouel Boudjnah <chmouel@xxxxxxxxxxxxxxxx>
Subject: Re: reenabling quota after xfs_repair
From: Nathan Scott <nathans@xxxxxxx>
Date: Fri, 19 Oct 2001 17:15:08 +1100
Cc: linux-xfs@xxxxxxxxxxx
In-reply-to: <20011019080104.A31567@xxxxxxxxxxxxxxx>; from robert.sander@xxxxxxxxxxxxxxx on Fri, Oct 19, 2001 at 08:01:04AM +0200
References: <robert.sander@xxxxxxxxxxxxxxx> <200110171613.f9HGDhW17816@xxxxxxxxxxxxxxxxxxxx> <20011018112928.B522717@xxxxxxxxxxxxxxxxxxxxxxxx> <20011019063540.A16377@xxxxxxxxxxxxxxx> <20011019163334.E457588@xxxxxxxxxxxxxxxxxxxxxxxx> <20011019080104.A31567@xxxxxxxxxxxxxxx>
Sender: owner-linux-xfs@xxxxxxxxxxx
User-agent: Mutt/1.2.5i
hi Robert,

On Fri, Oct 19, 2001 at 08:01:04AM +0200, Robert Sander wrote:
> On Fri, Oct 19, 2001 at 04:33:34PM +1100, Nathan Scott wrote:
> > We could be seeing a problem with the system call getting into
> > XFS (this would be a kernel problem) - has happened before with
> > some incorrect patches and one of our initial releases was even
> > botched this way actually.  Which kernel version are you using
> > (CVS?, a release kernel?, patch? - which patch)?
> 

Yup, its the exact same problem - fs/dquot.c has been merged
incorrectly.  So close, but one subtle issue was missed.

> Currently I am using the Mandrake 2.4.8 kernel from
> http://iserv.nl/files/xfs/ compiled with gcc 2.91.66
> 
> I'll send them to you by private email.
> 

Thanks for that.  Hopefully the Mandrake folk can pick up this
fix before their final release.  The patch to the fs/dquot.c
you sent me is below.

Many thanks for reporting this!

cheers.

-- 
Nathan


--- dquot.c.orig        Fri Oct 19 16:06:13 2001
+++ dquot.c     Fri Oct 19 16:06:45 2001
@@ -2012,7 +2012,7 @@
        type = cmd & SUBCMDMASK;
 
 
-       if ((uint) type >= MAXQUOTAS || cmds > 0x1100 || cmds < 0x100 || cmds 
== 0x0300 ||
+       if ((uint) type >= MAXQUOTAS || cmds < 0x100 || cmds == 0x0300 ||
            cmds == 0x0400 || cmds == 0x0500 || cmds == 0x1000)
                goto out;
 


<Prev in Thread] Current Thread [Next in Thread>