xfs
[Top] [All Lists]

Re: include/acl.h in 2.4.13-pre2

To: Keith Owens <kaos@xxxxxxxxxxxxxxxxx>
Subject: Re: include/acl.h in 2.4.13-pre2
From: Nathan Scott <nathans@xxxxxxx>
Date: Mon, 15 Oct 2001 09:03:46 +1100
Cc: "Bernhard R. Erdmann" <be@xxxxxxxxxxx>, linux-xfs@xxxxxxxxxxx
In-reply-to: <2217.1003062220@xxxxxxxxxxxxxxxxxxxxx>; from kaos@xxxxxxxxxxxxxxxxx on Sun, Oct 14, 2001 at 10:23:40PM +1000
References: <3BC98090.BA78FC5A@xxxxxxxxxxx> <2217.1003062220@xxxxxxxxxxxxxxxxxxxxx>
Sender: owner-linux-xfs@xxxxxxxxxxx
User-agent: Mutt/1.2.5i
On Sun, Oct 14, 2001 at 10:23:40PM +1000, Keith Owens wrote:
> On Sun, 14 Oct 2001 14:09:52 +0200, 
> >Steve Lord wrote:
> >> 
> >> Try running make dep, it all builds for me.
> >
> >I did (make mrproper, cp some/where/.config ., make oldconfig, make dep
> >clean bzImage modules modules_install), but it fails to compile on RH
> >6.1/6.2.
> >On RH 7.1 all is ok as you reported.
> 
> Arrgh!  RH 7.1 is picking up /usr/include/linux/acl.h which is a real
> file.  On RH 6 usr/include/linux is normally a symlink to
> /usr/src/linux so you get different files depending on which kernel you
> have installed.  Linus has fought against this for ages because it
> generated wierd kernels, most distributions now ship a copy of the
> files in /usr/include/linux instead of symlinking to some random
> kernel.
> 
> I guess that Nathan's build was on a system which had a real file for
> /usr/include/linux/acl.h so he did not get a compile error.

No, the problem was that I only did builds with CONFIG_POSIX_ACL
enabled, so for me this file (noposix_acl.c) was never built, so
was not updated.

The correct fix, as Bernhard suggested, is to simply remove the
<linux/acl.h> include line.

thanks.

-- 
Nathan


<Prev in Thread] Current Thread [Next in Thread>