xfs
[Top] [All Lists]

Re:TAKE - fix ABBA deadlock under heavy load

To: Steve Lord <lord@xxxxxxx>
Subject: Re:TAKE - fix ABBA deadlock under heavy load
From: Amit D Chaudhary <amitc@xxxxxxxxxxx>
Date: Thu, 11 Oct 2001 19:03:54 -0700
Cc: linux-xfs list <linux-xfs@xxxxxxxxxxx>
Sender: owner-linux-xfs@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.3) Gecko/20010801
Hi,

This has been posted sometime back, I have a rather simple query, should this change be applied to xfs 1.0.1 on 2.4.2?

Since it is mentioned that it was needed for an earlier version and we happen to be at an earlier version, it is prudent to check.

Thanks and Regards
Amit

The diff
http://oss.sgi.com/cgi-bin/cvsweb.cgi/linux-2.4-xfs/linux/fs/xfs/xfs_vnodeops.c.diff?r1=1.507&r2=1.508

The original email
------------------------------------------------------------

This may be what Andrew Tridgell hit, I hit it running dbench 140
and deadlocked between kswapd reclaiming inodes and kupdated
flushing inodes. 160 stack traces later......


Date:  Tue Aug 14 14:58:24 PDT 2001
Workarea:  jen.americas.sgi.com:/src/lord/xfs-linux.2.4

The following file(s) were checked into:
  bonnie.engr.sgi.com:/isms/slinx/2.4.x-xfs


Modid:  2.4.x-xfs:slinx:100765a
linux/fs/xfs/xfs_vnodeops.c - 1.508
        - Remove ABBA deadlock between ilock and ihash lock, the ihash lock in
          xfs_finish_reclaim is a hang over from an earlier implementation on
          Linux, we do not need it anymore, and at some point this deadlock
          got introduced.






<Prev in Thread] Current Thread [Next in Thread>
  • Re:TAKE - fix ABBA deadlock under heavy load, Amit D Chaudhary <=