Upgrading kernel, Compile error in module

[Micah Yoder <yodermk@xxxxxxxx>]

Hi again.  Decided it was finally time to upgrade my 2.4.6pre2-xfs, which has 
been working great, for security and VM fixes.  Just grabbed latest CVS an 
hour or two ago (2.4.14pre3).

Thing that makes me nervous is that there was a minor compile error in gvim 
./drivers/block/paride/pcd.c:

static struct block_device_operations pcd_bdops = {
        owner:                  THIS_MODULE,
        open:                   cdrom_open,
        release:                cdrom_release,
        ioctl:                  cdrom_ioctl,
        check_media_change:     cdrom_media_changed,
}   /* line 274 */

static struct cdrom_device_ops pcd_dops = {
        pcd_open,
        pcd_release,
[...]

Note the lack of a semicolon on 274!!!  I added it and now it compiles.  
Dunno if that booboo was inherited from Linus or from one of you, but you 
might want to fix it. :-)

So that's fixed, but the fact that it was there worries me some!  What other 
nasties besides compile errors could be in there?

Also I'm a bit amused that the sizes of bzImage and vmlinuz are SMALLER than 
with my previous kernel.  I configured this with make oldconfig and answered 
N (default) to all new features.  Was a bit tempted by XFS_QUOTA but decided 
to pass on it for now.

Think it's "safe" to put this thing on a production server?  Again, my 
"problem" is that it's co-located, 500 miles away, so a mistake could be 
costly...  but if it works for most people I'm willing to try it.

Thanks,
Micah

-- 
Like to travel?                        http://TravTalk.org
Micah Yoder Internet Development       http://yoderdev.com