xfs
[Top] [All Lists]

Re: Busy inodes after umount

To: Ragnar Kjørstad <xfs@xxxxxxxxxxxxxxxxxxx>
Subject: Re: Busy inodes after umount
From: Neil Brown <neilb@xxxxxxxxxxxxxxx>
Date: Thu, 2 Aug 2001 21:34:17 +1000 (EST)
Cc: Tad Dolphay <tbd@xxxxxxx>, mjacob@xxxxxxxxx, Christian Chip <chip.christian@xxxxxxxxxxxxxxx>, linux-xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, nfs@xxxxxxxxxxxxxxxxxxxxx
In-reply-to: message from Ragnar Kjørstad on Tuesday July 31
References: <20010719165758.D50024-100000@xxxxxxxxxxxxxxx> <200107200038.TAA40153@xxxxxxxxxxxxxxxxxxxxxxxx> <20010731021546.A7750@xxxxxxxxxxx>
Sender: owner-linux-xfs@xxxxxxxxxxx
On Tuesday July 31, xfs@xxxxxxxxxxxxxxxxxxx wrote:
> On Thu, Jul 19, 2001 at 07:38:15PM -0500, Tad Dolphay wrote:
> > > > I've now been able to reproduce:
> > > >
> > > > * make a filesystem
> > > > * mount it
> > > > * export it (nfs)
> > > > * mount on remote machine
> > > > * lock file (fcntl)
> > > > * unexport
> > > > * unmount
> > > >
> > > > Then you get the VFS message about self-destruct. Tested with both ext2
> > > > and xfs.
> > > >
> > > > The lock is still present in /proc/locks after the umount.
> > > >
> > > > With ext2 I can remount the filesystem successfully, but with XFS I get
> > > > the message about duplicate UUIDs and the mount failes. I believe this 
> > > > is a totally
> > > > different problem from the one you were experiencing. (and blockdev 
> > > > doesn't help for me)
> > > >
> > > > I suppose this is a generic kernel bug?

Yep.  It is not filesystem specific.  
nfsd does not flush locks when a filesystem is un-exported, only when
a client is removed, and that actually never happens.
In fs/nfsd/lockd.c there is a comment:

/*
 * When removing an NFS client entry, notify lockd that it is gone.
 * FIXME: We should do the same when unexporting an NFS volume.
 */

That FIXME needs to be fixed.  I need to read through some more code
before I am sure how to do it, but it shouldn't be too hard.

NeilBrown


<Prev in Thread] Current Thread [Next in Thread>