Re: do_softirq

[Keith Owens <kaos@xxxxxxxxxxxxxxxxx>]

On Fri, 15 Jun 2001 01:47:05 +0200, 
"Bernhard R. Erdmann" <be@xxxxxxxxxxx> wrote:
>Having compiled 2.4.6-pre3-xfs, I get an unresolved symbol in
>ppp_generic.o:
>
># /sbin/depmod -a -e
>depmod: *** Unresolved symbols in
>/lib/modules/2.4.6-pre3-xfs/kernel/drivers/net/ppp_generic.o
>depmod:        do_softirq

Kernel bug, not XFS.  Patch has been sent to Linus.

Index: 6-pre3.1/include/asm-i386/softirq.h
--- 6-pre3.1/include/asm-i386/softirq.h Sat, 09 Jun 2001 11:25:53 +1000 kaos 
(linux-2.4/T/51_softirq.h 1.3 644)
+++ 6-pre3.1(w)/include/asm-i386/softirq.h Thu, 14 Jun 2001 02:26:16 +1000 kaos 
(linux-2.4/T/51_softirq.h 1.3 644)
@@ -36,13 +36,13 @@ do {                                                        
                \
                                                                        \
                        ".section .text.lock,\"ax\";"                   \
                        "2: pushl %%eax; pushl %%ecx; pushl %%edx;"     \
-                       "call do_softirq;"                              \
+                       "call %c1;"                                     \
                        "popl %%edx; popl %%ecx; popl %%eax;"           \
                        "jmp 1b;"                                       \
                        ".previous;"                                    \
                                                                        \
                : /* no output */                                       \
-               : "r" (ptr)                                             \
+               : "r" (ptr), "i" (do_softirq)                           \
                /* no registers clobbered */ );                         \
 } while (0)