Proper bug report on RH-2.4.5 config failure :)

[Alan Eldridge <alane@xxxxxxxxxxxx>]

On Sat, Jun 09, 2001 at 12:16:59PM +1000, Keith Owens wrote:
>On Fri, 8 Jun 2001 21:34:20 -0400, 
>Alan Eldridge <alane@xxxxxxxxxxxx> wrote:
>>+++ linux/fs/Config.in        Fri Jun  8 21:09:35 2001
>>+[ $CONFIG_PAGE_BUF ] || CONFIG_PAGE_BUF=y
>
>Arrgh, please do not use shell code in config.in files.  The config
>language is *NOT* shell, the above will work for some parsers but not
>all of them.

Saw that soon after. I forgot that shell is but one implementation. :)
I'll rerun the faulty ocnfig.... The symptom is that the vars aren't set the
first time through the configure, so it fails with "no default"....
"default" in this case means, the shell var wasn't set, and so the var name
went into the "nodefaults" file.

Sorry 'bout the inappropriate solution ... I kinda forgot that, unlike some
other mailing lists, here I'm dealing with people who know what they're
doing, and know more about it than I do.... :)

OK ...

Here's the patch as Russell supplied it:

---8<-snip---8<-snip---8<-snip---8<-snip---8<-snip---8<-snip---8<---
--- /build/RH_raw/linux/fs/Config.in    Wed Jun  6 12:38:09 2001
+++ linux/fs/Config.in  Thu Jun  7 23:48:41 2001
@@ -5,6 +5,7 @@
 comment 'File systems'
 
 bool 'Quota support' CONFIG_QUOTA
+bool 'POSIX Access Control List support' CONFIG_FS_POSIX_ACL
 tristate 'Kernel automounter support' CONFIG_AUTOFS_FS
 tristate 'Kernel automounter version 4 support (also supports v3)' 
CONFIG_AUTOFS4_FS
 
@@ -84,6 +85,19 @@
 
 tristate 'UFS file system support (read only)' CONFIG_UFS_FS
 dep_mbool '  UFS file system write support (DANGEROUS)' CONFIG_UFS_FS_WRITE 
$CONFIG_UFS_FS $CONFIG_EXPERIMENTAL
+
+tristate 'Page Buffer support' CONFIG_PAGE_BUF
+
+if [ "$CONFIG_PAGE_BUF" = "n" ]; then
+   comment '  Page Buffer support needed for XFS filesystem'
+else
+   dep_tristate 'SGI XFS filesystem support' CONFIG_XFS_FS $CONFIG_PAGE_BUF
+   if [ "$CONFIG_XFS_FS" != "n" ]; then
+      define_bool CONFIG_HAVE_ATTRCTL y
+      dep_mbool '  Enable XFS DMAPI' CONFIG_XFS_DMAPI $CONFIG_XFS_FS
+      dep_mbool '  Enable XFS Quota' CONFIG_XFS_QUOTA $CONFIG_XFS_FS 
$CONFIG_QUOTA
+   fi
+fi
 
 if [ "$CONFIG_NET" = "y" ]; then
 
---8<-snip---8<-snip---8<-snip---8<-snip---8<-snip---8<-snip---8<---

Here's the relevant bits of the resulting fs/Config.in:

---8<-snip---8<-snip---8<-snip---8<-snip---8<-snip---8<-snip---8<---
#
# File system configuration
#
mainmenu_option next_comment
comment 'File systems'

bool 'Quota support' CONFIG_QUOTA
bool 'POSIX Access Control List support' CONFIG_FS_POSIX_ACL
tristate 'Kernel automounter support' CONFIG_AUTOFS_FS
[ ... ]
tristate 'UFS file system support (read only)' CONFIG_UFS_FS
dep_mbool '  UFS file system write support (DANGEROUS)' CONFIG_UFS_FS_WRITE 
$CONFIG_UFS_FS $CONFIG_EXPERIMENTAL

tristate 'Page Buffer support' CONFIG_PAGE_BUF

if [ "$CONFIG_PAGE_BUF" = "n" ]; then
   comment '  Page Buffer support needed for XFS filesystem'
else
   dep_tristate 'SGI XFS filesystem support' CONFIG_XFS_FS $CONFIG_PAGE_BUF
   if [ "$CONFIG_XFS_FS" != "n" ]; then
      define_bool CONFIG_HAVE_ATTRCTL y
      dep_mbool '  Enable XFS DMAPI' CONFIG_XFS_DMAPI $CONFIG_XFS_FS
      dep_mbool '  Enable XFS Quota' CONFIG_XFS_QUOTA $CONFIG_XFS_FS 
$CONFIG_QUOTA
   fi
fi

if [ "$CONFIG_NET" = "y" ]; then

   mainmenu_option next_comment
   comment 'Network File Systems'
[ ... ]
---8<-snip---8<-snip---8<-snip---8<-snip---8<-snip---8<-snip---8<---

And here's the "rpm -bc kernel-2.4-xfs.spec" run, trimmed to the running of
the "make oldconfig_nonint" step:

Script started on Fri Jun  8 23:08:32 2001
[ ... ]
UFS file system support (read only) (CONFIG_UFS_FS) [M/n/y/?] 
  UFS file system write support (DANGEROUS) (CONFIG_UFS_FS_WRITE) [N/y/?] 
Page Buffer support (CONFIG_PAGE_BUF) [N/y/m/?] (NEW) *
*   Page Buffer support needed for XFS filesystem
*
[ note page buffer, XFS are turned off ]
*
* Network File Systems
*
[ ... ]
* Kernel hacking
*
  Magic SysRq key (CONFIG_MAGIC_SYSRQ) [Y/n/?] 
Kernel debugging (CONFIG_DEBUG_KERNEL) [N/y/?] 

*** End of Linux kernel configuration.
*** Check the top-level Makefile for additional configuration.
*** Next, you must run 'make dep'.

The following defaults are missing:
POSIX Access Control List support (CONFIG_FS_POSIX_ACL) [N/y/?] 
Page Buffer support (CONFIG_PAGE_BUF) [N/y/m/?] 
make: *** [oldconfig_nonint] Error 1
error: Bad exit status from /home/alane/rpm/tmp/rpm-tmp.94446 (%build)


RPM build errors:
    Bad exit status from /home/alane/rpm/tmp/rpm-tmp.94446 (%build)
[alane@wwweasel SPECS]$ exit
Script done on Fri Jun  8 23:11:07 2001

-- 
Alan Eldridge