xfs
[Top] [All Lists]

Re: dump/restore and setuid/setgid files

To: Brent A Nelson <brent@xxxxxxxxxxxx>
Subject: Re: dump/restore and setuid/setgid files
From: Eric Sandeen <sandeen@xxxxxxx>
Date: Thu, 17 May 2001 16:48:52 -0500
Cc: linux-xfs@xxxxxxxxxxx
References: <Pine.GSO.4.21.0105171734300.22735-100000@xxxxxxxxxxxxxxxxxxxx>
Sender: owner-linux-xfs@xxxxxxxxxxx
Brent A Nelson wrote:
> 
> I'm using an xfsdump piped to an xfsrestore to copy files from my root
> partition to a logical volume (as part of a convoluted script I'm using
> after Kickstart, since RedHat doesn't include LVM support in their
> installer).  One thing I noticed, though, is that the setuid and setgid
> bits aren't preserved on the restored files.  Is there any way around
> this?

This is fixed in the devel tree, you can look at cvsweb on
oss.sgi.com/projects/xfs to extract the patches you need, or just grab
the whole devel tree...

-Eric

from checkin announcement:

> This fixes the problem with xfsrestore not restoring the suid or guid
> modes on a file.
> It occurred because a chown was done after the chmod when restoring
> the files and the chown was clearing these mode bits even running as root.
> On IRIX, as root, this is not the case.
> The Linux man page indicates that this behavior for root is dependent
> on the kernel version. 
> Anyway, I have changed the ordering so that the chown is done before
> the chmod and test 056 now passes.

> Date:  Mon May 14 21:05:35 PDT 2001
> Workarea:  snort.melbourne.sgi.com:/diskb/build4/tes/slinx-xfs-acl
> 
> The following file(s) were checked into:
>   bonnie.engr.sgi.com:/isms/slinx/2.4.x-xfs
> 
> 
> Modid:  2.4.x-xfs:slinx:94886a

<snip>

> cmd/xfsdump/restore/tree.c - 1.4
>         - Make chown come before chmod so that suid and guid bits are not 
> cleared
>           when restoring directories.
> 
> cmd/xfsdump/common/arch_xlate.c - 1.4
>         - Add some diags for ino and mode on bstat translation.
> 
> cmd/xfsdump/restore/content.c - 1.7
>         - Make chown come before chmod so that suid and guid bits are not 
> cleared
>           when restoring regular files.


-- 
Eric Sandeen      XFS for Linux     http://oss.sgi.com/projects/xfs
sandeen@xxxxxxx   SGI, Inc.

<Prev in Thread] Current Thread [Next in Thread>