xfs
[Top] [All Lists]

Re: xfsdump safe?

To: Ivan Rayner <ivanr@xxxxxxxxxxxxxxxxx>
Subject: Re: xfsdump safe?
From: Andi Kleen <ak@xxxxxxx>
Date: Fri, 11 May 2001 14:54:53 +0200
Cc: Andi Kleen <ak@xxxxxxx>, linux-xfs@xxxxxxxxxxx
In-reply-to: <Pine.SGI.4.32.0105112222550.48503-100000@omen.melbourne.sgi.com>; from ivanr@melbourne.sgi.com on Fri, May 11, 2001 at 10:31:46PM +1000
References: <20010511122945.A5907@gruyere.muc.suse.de> <Pine.SGI.4.32.0105112222550.48503-100000@omen.melbourne.sgi.com>
Sender: owner-linux-xfs@xxxxxxxxxxx
User-agent: Mutt/1.2.5i
On Fri, May 11, 2001 at 10:31:46PM +1000, Ivan Rayner wrote:
> On Fri, 11 May 2001, Andi Kleen wrote:
> 
> > Regarding xfsdump:
> >
> > The qlock functions seem to be dummied out (inside #ifdef HIDDEN), but
> > it still seems to create threads in some circumstances, which probably need
> > locking. Is it really safe to use?
> 
> I think you'll find that the linux version of xfsdump runs in single
> threaded mode.  This is controlled by the 'miniroot' flag which is set to
> true on Linux - the key bits are around line 604 in cmd/xfsdump/common/main.c.

As far as I can see common/drive_{scsitape,minrmt}.c do not check that 
flag before calling cldmgr_create()


-Andi

<Prev in Thread] Current Thread [Next in Thread>