This TAKE modifies the non-xfs files of:
linux/include/linux/fs.h
linux/fs/namei.c
I needed to modify namie.c so that the umask would not
unconditionally be applied to the mode - otherwise the
default ACL has no chance of being applied correctly.
Andreas G. did the same thing for his linux/ext2 ACL patch.
I don't know if this is really urgent enough to go into 1.0 .
I would certainly like it go thru QA for a bit and others may
have some better suggestions for the fix.
--Tim
Date: Mon Apr 16 22:16:51 PDT 2001
Workarea: snort.melbourne.sgi.com:/diskb/build4/tes/slinx-xfs-acl
The following file(s) were checked into:
bonnie.engr.sgi.com:/isms/slinx/2.4.x-xfs
Modid: 2.4.x-xfs:slinx:92683a
linux/include/linux/fs.h - 1.89
- pv#820248; rv:ajag@engr;
Add IS_POSIX_ACL() macro and acl_flag to the super block.
linux/fs/namei.c - 1.27
- pv#820248; rv:ajag@engr
Don't apply umask if ACLs turned on for FS.
This is done like Andreas Gruenbacher's ACL patch.
linux/fs/xfs/linux/xfs_super.c - 1.117
- pv#820248; rv:ajag@engr
Turn on the acl flag for xfs.
linux/fs/xfs/linux/xfs_iops.c - 1.104
- pv#820248; rv:ajag@engr
Modify linvfs_common_cr() so that if a default acl does
not exist for the parent inode (using _ACL_GET_DEFAULT())
then apply the umask. Otherwise use the default acl for
_ACL_INHERIT().
cmd/xfstests/051.out - 1.6
- Updated for 051 change for pv#820248.
cmd/xfstests/051 - 1.6
- Test default ACLs with particular umasks instead of
relying on a default umask.
Updated for pv#820248.
linux/fs/xfs/xfs_acl.h - 1.4
- pv#820248; rv:ajag@engr;
Fix up the parameters for _ACL_INHERIT and add _ACL_GET_DEFAULT.
linux/fs/xfs/xfs_acl.c - 1.4
- pv#820248; rv:ajag@engr;
Change xfs_acl_inherit() to take the parent's default acl as
a parameter instead of getting it from the parent's vnode.
This is done because in linvfs_common_cr() we will already have
gotten the default ACL and so we should use it instead of getting
it again.
ALSO, fix the bug where the group permission of the mode was not
and'ed in - it was just overwriting the group permission.
|