xfs
[Top] [All Lists]

Re: linux-2.4-xfs build broken

To: Aaron Lehmann <aaronl@xxxxxxxxxxx>, Andi Kleen <ak@xxxxxxx>, kaos@xxxxxxxxxxxxxxxxxxxxxxx
Subject: Re: linux-2.4-xfs build broken
From: "Nathan Scott" <nathans@xxxxxxxxxxxxxxxxxxxxxxxx>
Date: Tue, 10 Apr 2001 09:00:40 -0500
Cc: linux-xfs@xxxxxxxxxxx
In-reply-to: Aaron Lehmann <aaronl@vitelus.com> "Re: linux-2.4-xfs build broken" (Apr 9, 1:53am)
References: <20010407161914.A4860@vitelus.com> <3ACFD59D.67BF49E1@thebarn.com> <20010409005723.A25023@vitelus.com> <20010409100516.A21515@gruyere.muc.suse.de> <20010409012728.A27832@vitelus.com> <20010409103219.B22252@gruyere.muc.suse.de> <20010409014147.C27832@vitelus.com> <20010409104356.A22565@gruyere.muc.suse.de> <20010409014636.D27832@vitelus.com> <20010409104946.A22772@gruyere.muc.suse.de> <20010409015338.E27832@vitelus.com>
Sender: owner-linux-xfs@xxxxxxxxxxx
hi,

On Apr 9,  1:53am, Aaron Lehmann wrote:
> Subject: Re: linux-2.4-xfs build broken
> On Mon, Apr 09, 2001 at 10:49:46AM +0200, Andi Kleen wrote:
> > In this case you should have gotten an error from the Makefile in
> > drivers/char, except if you have something else also called loadkeys in your
> > $PATH. 
> 
> loadkeys --mktable defkeymap.map | sed -e 's/^static *//' > defkeymap.c
> /bin/sh: loadkeys: command not found
> gcc -V egcs-2.91.66 -D__KERNEL__ -I/usr/src/linux-2.4-xfs/linux/include  
> -Wall -Wstrict-prototypes -O2 -fno-strict-aliasing -fomit-frame-pointer -pipe 
>  -march=i586    -c -o defkeymap.o defkeymap.c
> 
> 
> That's really weird. It should have stopped the build.
> 

this has come up once before on the list - a couple of months
ago I think.  the Makefile is broken - in the line you've given
above, the failed return code from loadkeys-not-found is lost
because of the sed (the return code is that of the last command
in the pipeline & sed doesn't fail here, so make doesn't detect
the failure).

if I remember correctly, this Makefile change comes from kdb -
I think Keith knows about this problem.  could probably use an
intermediate temporary file to get around this buglet, Keith?

cheers.

-- 
Nathan

<Prev in Thread] Current Thread [Next in Thread>