Jens Axboe <axboe@xxxxxxx> wrote:
> On Tue, Feb 27 2001, Thomas Graichen wrote:
>> just tried to apply the loop-6 patch to the XFS tree (which works
>> fine with plain 2.4.2) i ran into the following:
>>
>> kgcc -D__KERNEL__ -I/tmp/linux/include -Wall -Wstrict-prototypes -O2
>> -fno-strict-aliasing -pipe -march=i686 -c -o rd.o rd.c
>> rd.c: In function `rd_init':
>> rd.c:408: warning: passing arg 2 of `blk_queue_make_request' from
>> incompatible pointer type
>> kgcc -D__KERNEL__ -I/tmp/linux/include -Wall -Wstrict-prototypes -O2
>> -fno-strict-aliasing -pipe -march=i686 -DEXPORT_SYMTAB -c loop.c
>> loop.c: In function `loop_make_request':
>> loop.c:451: too few arguments to function `generic_make_request'
>> loop.c: In function `loop_init':
>> loop.c:954: warning: passing arg 2 of `blk_queue_make_request' from
>> incompatible pointer type
>> make[3]: *** [loop.o] Error 1
>> make[3]: Leaving directory `/tmp/linux/drivers/block'
>> make[2]: *** [first_rule] Error 2
>> make[2]: Leaving directory `/tmp/linux/drivers/block'
>> make[1]: *** [_subdir_block] Error 2
>> make[1]: Leaving directory `/tmp/linux/drivers'
>> make: *** [_dir_drivers] Error 2
>>
>> ... and because i think jens is lurking around here i try to
>> ask first before looking into it ... maybe he already has
>> a fix handy
> Yeah, the lurker, that's me :-)
> Anways, change the generic_make_request in loop to something like:
> generic_make_request(rw, bh, NULL, 0, 0, 0);
> return 0;
> and loop_make_request definition to:
> static int loop_make_request(request_queue_t *q, int rw,
> struct buffer_head *rbh, struct kio_buf *kio,
> kdev_t dev, unsigned long block, size_t bsize)
i assume the kio_buf is kiobuf above? - then it compiles fine
(only sidething is: loop.c: In function `loop_init': loop.c:956:
warning: passing arg 2 of `blk_queue_make_request' from incompatible
pointer type ... same for rd.c)
t
--
thomas.graichen@xxxxxxxxxxxxxx
innominate AG
the linux architects
tel: +49-30-308806-13 fax: -77 http://www.innominate.com
|