xfs
[Top] [All Lists]

TAKE - more pagebuf cleanup and fix a potential bug

To: unlisted-recipients:; (no To-header on input)
Subject: TAKE - more pagebuf cleanup and fix a potential bug
From: Steve Lord <lord@xxxxxxx>
Date: Fri, 9 Feb 2001 17:48:38 -0600
Sender: owner-linux-xfs@xxxxxxxxxxx
I did not like the way we cleared delalloc state on a page before
getting an extra reference on it. That's one line, most of this
is dead code cleanup.

Date:  Fri Feb  9 15:48:44 PST 2001
Workarea:  jen.americas.sgi.com:/src/lord/xfs-linux.2.4

The following file(s) were checked into:
  bonnie.engr.sgi.com:/isms/slinx/2.4.x-xfs


Modid:  2.4.x-xfs:slinx:87227a
linux/include/linux/page_buf.h - 1.73
        - Changed prototype for _pagebuf_lookup_pages(), remove some unused
          definitions.

linux/fs/pagebuf/page_buf.c - 1.52
        - Remove unused code from the _pagebuf_lookup_pages() function, it had
          the capability to populate partial pagebufs, this is not used, and is
          somewhat obscure code.

linux/fs/pagebuf/page_buf_io.c - 1.50
        - In the read_full_page path always attach buffer heads to pages, this
          appears to help. change calls to _pagebuf_lookup_pages to remove 
deleted
          parameters, use page_cache calls instead of direct page calls, and
          in the delalloc conversion path, take a reference on the page being
          converted before removing the delalloc flag.



<Prev in Thread] Current Thread [Next in Thread>
  • TAKE - more pagebuf cleanup and fix a potential bug, Steve Lord <=