xfs
[Top] [All Lists]

Re: patch: double freereq freeing

To: Jens Axboe <axboe@xxxxxxx>
Subject: Re: patch: double freereq freeing
From: Russell Cattelan <cattelan@xxxxxxxxxxx>
Date: Sun, 10 Dec 2000 15:15:09 -0600
Cc: linux-xfs@xxxxxxxxxxx
References: <20001210215635.E294@xxxxxxx>
Sender: owner-linux-xfs@xxxxxxxxxxx
Jens Axboe wrote:

> Hi again,
>
> This looks like a merge error. I sent this to Russell last week too,
> when investigating the recent kio/elevator problems. It's not critical,
> blkdev_release_request clears rq->q and thus it will not be freed
> twice.

I have that one in the tree with the elevator patch.
I never got around to checking that particular fix in.

I'm building the tree now I'll check in both fixes once
I verify it builds.

BTW as far as your elevator patch goes do you know if
will be part of test12?


>
>
> Index: drivers/block/ll_rw_blk.c
> ===================================================================
> RCS file: /cvs/linux-2.4-xfs/linux/drivers/block/ll_rw_blk.c,v
> retrieving revision 1.53
> diff -u -r1.53 ll_rw_blk.c
> --- drivers/block/ll_rw_blk.c   2000/12/01 18:04:38     1.53
> +++ drivers/block/ll_rw_blk.c   2000/12/10 20:49:41
> @@ -1013,8 +1014,6 @@
>         req_new_io(req, 0, count);
>         add_request(q, req, head, latency);
>  out:
> -       if (freereq)
> -               blkdev_release_request(freereq);
>         if (!q->plugged)
>                 (q->request_fn)(q);
>         if (freereq)
>
> --
> * Jens Axboe <axboe@xxxxxxx>
> * SuSE Labs


<Prev in Thread] Current Thread [Next in Thread>