xfs
[Top] [All Lists]

patch: double freereq freeing

To: linux-xfs@xxxxxxxxxxx
Subject: patch: double freereq freeing
From: Jens Axboe <axboe@xxxxxxx>
Date: Sun, 10 Dec 2000 21:56:35 +0100
Sender: owner-linux-xfs@xxxxxxxxxxx
Hi again,

This looks like a merge error. I sent this to Russell last week too,
when investigating the recent kio/elevator problems. It's not critical,
blkdev_release_request clears rq->q and thus it will not be freed
twice.

Index: drivers/block/ll_rw_blk.c
===================================================================
RCS file: /cvs/linux-2.4-xfs/linux/drivers/block/ll_rw_blk.c,v
retrieving revision 1.53
diff -u -r1.53 ll_rw_blk.c
--- drivers/block/ll_rw_blk.c   2000/12/01 18:04:38     1.53
+++ drivers/block/ll_rw_blk.c   2000/12/10 20:49:41
@@ -1013,8 +1014,6 @@
        req_new_io(req, 0, count);
        add_request(q, req, head, latency);
 out:
-       if (freereq)
-               blkdev_release_request(freereq);
        if (!q->plugged)
                (q->request_fn)(q);
        if (freereq)

-- 
* Jens Axboe <axboe@xxxxxxx>
* SuSE Labs

<Prev in Thread] Current Thread [Next in Thread>