xfs
[Top] [All Lists]

Re: HEADS UP test11 merge.

To: Russell Cattelan <cattelan@xxxxxxxxxxx>
Subject: Re: HEADS UP test11 merge.
From: Andi Kleen <ak@xxxxxxx>
Date: Sat, 25 Nov 2000 20:40:31 +0100
Cc: linux-xfs-announce@xxxxxxxxxxx, linux-xfs@xxxxxxxxxxx
In-reply-to: <3A1E9FAE.AB853C4A@xxxxxxxxxxx>; from cattelan@xxxxxxxxxxx on Fri, Nov 24, 2000 at 11:04:46AM -0600
References: <3A1E9FAE.AB853C4A@xxxxxxxxxxx>
Sender: owner-linux-xfs@xxxxxxxxxxx
User-agent: Mutt/1.2.5i
On Fri, Nov 24, 2000 at 11:04:46AM -0600, Russell Cattelan wrote:
> I have the XFS development tree patched up to test11, and ready to
> checkin.
> 
> I'm going to run a few more tests just to make sure nothing major broke.
> 
> I will try to finalize  the checkin later today if nobody has any major
> objections.

I needed this patch from Russel King to load xfs again (without it the module
loading put zeroes where support_init should be, causing a crash) 
This was with modutils 2.3.14.

--- ../linux.vanilla/kernel/module.c    Mon Nov 20 15:12:17 2000
+++ kernel/module.c     Thu Nov 23 11:49:42 2000
@@ -480,7 +480,9 @@
 
        /* Ok, that's about all the sanity we can stomach; copy the rest.  */
 
-       if (copy_from_user(mod+1, mod_user+1, mod->size-sizeof(*mod))) {
+       if (copy_from_user((char *)mod+mod_user_size,
+                          (char *)mod_user+mod_user_size,
+                          mod->size-mod_user_size)) {
                error = -EFAULT;
                goto err3;
        }



-Andi

<Prev in Thread] Current Thread [Next in Thread>