xfs
[Top] [All Lists]

Re: initial raid1 kiobuf support

To: linux-xfs@xxxxxxxxxxx
Subject: Re: initial raid1 kiobuf support
From: Marcelo Tosatti <marcelo@xxxxxxxxxxxxxxxx>
Date: Fri, 24 Nov 2000 19:23:59 -0200 (BRST)
In-reply-to: <Pine.LNX.4.21.0011241821460.3967-200000@xxxxxxxxxxxxxxxxxxxxxx>
Sender: owner-linux-xfs@xxxxxxxxxxx
On Fri, 24 Nov 2000, Marcelo Tosatti wrote:

> 
> Hi, 
> 
> I'm attaching a patch which adds kiobuf IO support to the raid1 code. 
> 
> Its not complete yet --- it does not reschedule read requests to other
> mirrors of the raid1 array in case of a IO error. I hope to do that soon.
> 
> Also, I've modified generic_make_request() function and touched some other
> kernel bits.
> 
> The patch is against SGI XFS tree from 1 hour ago. 
> 
> Comments are welcome.

Silly mistake in my patch:

@@ -1231,7 +1232,7 @@
@@ -1231,7 +1232,7 @@
         * should try ll_rw_block()
         * for non-SCSI (e.g. IDE) disks.
         */
-        if (!SCSI_DISK_MAJOR(MAJOR(dev))) {
+       if (!SCSI_DISK_MAJOR(MAJOR(dev)) || MAJOR(dev) != MD_MAJOR) { 
                *error = -ENOSYS;
                goto end_io;
        }


 
@@ -1231,7 +1232,7 @@
         * should try ll_rw_block()
         * for non-SCSI (e.g. IDE) disks.
         */
-        if (!SCSI_DISK_MAJOR(MAJOR(dev))) {
+       if (!SCSI_DISK_MAJOR(MAJOR(dev)) && MAJOR(dev) != MD_MAJOR) { 
                *error = -ENOSYS;
                goto end_io;
        }





<Prev in Thread] Current Thread [Next in Thread>