View Incident:
http://co-op.engr.sgi.com/BugWorks/code/bwxquery.cgi?search=Search&wlong=1&view_type=Bug&wi=808328
Status : open Priority : 4
Assigned Engineer : dxm Submitter : dxm
*Modified User : dxm *Modified User Domain : engr
*Description :
xfs_support uses EXPORT_SYMBOL to export a bunch of symbols
into the kernel global symbol namespace. Some of the symbol
names are quite generic and hence potentially clash with other
exports.
Case in point is "copyin" and "copyout".
we can:
- move code back into XFS
- make simple functions static inline
.....
==========================
ADDITIONAL INFORMATION (ADD)
From: dxm@engr (BugWorks)
Date: Nov 21 2000 05:32:43PM
==========================
Well spotted Andi - I just moved the code, assuming it
was correct. I've sinced checked up on this.
Linux copy_to_user and copy_from_user return 0 on success, +ve on failure
Irix copyin and copyout return 0 on success, -1 on failure
So our wrappers were not quite right. What was a bigger problem
was that a bunch of ioctls were assuming that copy_to_user and
copy_from_user return an errno on error.
Modid: 2.4.x-xfs:slinx:78747a
Date: Tue Nov 21 17:32:17 PST 2000
Workarea: snort:/build1/people/dxm/isms/slinx-xfs
Author: dxm
The following file(s) were checked into:
bonnie.engr.sgi.com:/isms/slinx/2.4.x-xfs
cmd/xfs/stress/group - 1.51
- add 048 fault test
cmd/xfs/stress/src/Makefile - 1.20
- add fault.c
linux/fs/xfs/linux/xfs_ioctl.c - 1.24
- fix error checking on copy_to_user and copy_from_user
linux/fs/xfs/support/move.h - 1.3
- fix copyin/copyout wrappers
cmd/xfs/stress/048 - 1.1
- run fault to check ioctl return codes on bad user address
cmd/xfs/stress/048.out - 1.1
- output for 048
cmd/xfs/stress/src/fault.c - 1.1
- check return codes from ioctls on bad user address
|