Submitter : dxm Status : open
Assigned Engineer : dxm Priority : 4
*Modified Date : 11/21/00 *Modified User : dxm
*Modified User Domain : melbourne *Description :
xfs_support uses EXPORT_SYMBOL to export a bunch of symbols
into the kernel global symbol namespace. Some of the symbol
names are quite generic and hence potentially clash with other
exports.
Case in point is "copyin" and "copyout".
we can:
- move code back into XFS
- make simple functions static inline
.....
==========================
ADDITIONAL INFORMATION (ADD)
From: daniel moore <dxm@xxxxxxxxxxxxxxxxxxxxxxxx>
Date: Nov 21 2000 06:09:11AM
[pvnews version: 1.71]
==========================
Russell Cattelan writes:
=> > - prefix symbols and use macro aliasing to avoid
=> > changing all references to them
=>
=> This seems like the easiest.
Yep. But some, probably including "random", can just go back into
XFS.
=> Actually is there any reason we shouldn't just define copyin -> copy_from_u
=> ser and
=> copyout -> copy_to_user?
=>
=> The functions were probably originally done for debug purposes.
There's a comment there about side-effects when done with #define
so I just made them inline. Can't see how there could be a problem
however.
-----------------------------------------------------
Daniel Moore dxm@xxxxxxx
R&D Software Engineer Phone: +61-3-98348209
SGI Performance Tools Group Fax: +61-3-98132378
-----------------------------------------------------
|