xfs
[Top] [All Lists]

Re: nfs fix for test5

To: linux-xfs@xxxxxxxxxxx
Subject: Re: nfs fix for test5
From: Thomas Graichen <news-innominate.list.sgi.xfs@xxxxxxxxxxxxx>
Date: 27 Sep 2000 16:38:56 GMT
Distribution: local
Organization: innominate AG, Berlin, Germany
References: <ak@xxxxxxx> <200009271431.JAA01289@xxxxxxxxxxxxxxxxxxxx>
Reply-to: Thomas Graichen <graichen@xxxxxxxxxxxxx>
Reply-to: thomas.graichen@xxxxxxxxxxxxx
Sender: owner-linux-xfs@xxxxxxxxxxx
User-agent: tin/1.4.2-20000205 ("Possession") (UNIX) (Linux/2.4.0-test5 (i586))
Steve Lord <lord@xxxxxxx> wrote:
>> On Wed, Sep 27, 2000 at 02:18:48PM +0000, Thomas Graichen wrote:
>> > Index: write.c
>> > ===================================================================
>> > RCS file: /cvs/linux-2.4-xfs/linux/fs/nfs/write.c,v
>> > retrieving revision 1.18
>> > diff -u -r1.18 write.c
>> > --- write.c        2000/06/02 00:22:59     1.18
>> > +++ write.c        2000/09/27 14:06:28
>> > @@ -1294,7 +1294,7 @@
>> >    struct nfs_page         *req;
>> >    struct dentry           *dentry;
>> >    struct inode            *inode;
>> > -  loff_t                  start, end, len;
>> > +  u64                     start, end, len;
>> 
>> Looks bogus, loff_t is already 64bits. 
>> 
>> 
>> -Andi

> And I am still waiting for the coffee to kick in, but Andi is correct, this 
> is already 64 bits, but it is signed, so there may be something in the change,
> was there any commentry with the original change?

but it makes a difference - without i can't for instance do a
dd if=/dev/zero of=testfile on an mounted dir with it works
fine ... so there is something in it

you may find the whole thread at

  http://www.geocrawler.com/search/?config=789&words=%222.4.0-test5+client%22

> p.s. Thomas, looks like I will be in Miami after all.

that sounds fine

t

-- 
thomas.graichen@xxxxxxxxxxxxx
technical director                                       innominate AG
clustering & security                                networking people
tel: +49.30.308806-13  fax: -77                   http://innominate.de

<Prev in Thread] Current Thread [Next in Thread>