xfs
[Top] [All Lists]

ADD 801066 - Extra unneeded endian flipping in XFS code

To: dxm@xxxxxxxxxxxx
Subject: ADD 801066 - Extra unneeded endian flipping in XFS code
From: pv@xxxxxxxxxxxxx (nathans@xxxxxxxxxxxx)
Date: Wed, 6 Sep 2000 23:22:48 -0700 (PDT)
Cc: linux-xfs@xxxxxxxxxxx
Reply-to: sgi.bugs.xfs@xxxxxxxxxxxxxxxxx
Sender: owner-linux-xfs@xxxxxxxxxxx
Webexec: webpvupdate,pvincident
Webpv: wobbly.melbourne.sgi.com
View Incident: 
http://co-op.engr.sgi.com/BugWorks/code/bwxquery.cgi?search=Search&wlong=1&view_type=Bug&wi=801066

 Status : open                         Priority : 3                         
 Assigned Engineer : dxm               Submitter : lord                     
*Modified User : nathans              *Modified User Domain : engr          
*Description :
Capturing some old email state into a PV

I was digging through the code trying to figure out why the power pc is getting
zero inode numbers and I came across this code in xfs_inobt_get_rec

        INT_SET(*ino, arch, INT_GET(rec->ir_startino, ARCH_CONVERT));
        INT_SET(*fcnt, arch, INT_GET(rec->ir_freecount, ARCH_CONVERT));
        INT_SET(*free, arch, INT_GET(rec->ir_free, ARCH_CONVERT));

Places like xfs_dialloc are calling xfs_inobt_get_rec() several times with

.....


==========================
ADDITIONAL INFORMATION (ADD)
From: nathans@engr (BugWorks)
Date: Sep 06 2000 11:22:47PM
==========================

Could you also look into fixing the compiler warnings which the endian
macros sometimes generate when you get round to this one, Daniel?

The warnings are of the form (e.g. from xfs_repair):
attr_repair.c:268: warning: value computed is not used
and
dino_chunks.c:205: warning: left-hand operand of comma expression has no effect

We'd only be a hop, skip & a jump away from a clean user tool build then...

taa.

<Prev in Thread] Current Thread [Next in Thread>