xfs
[Top] [All Lists]

TAKE 801764 - xfs_check and xfs_repair should fail if device mounted

To: nathans@xxxxxxxxxxxxxxxxxxxx
Subject: TAKE 801764 - xfs_check and xfs_repair should fail if device mounted
From: pv@xxxxxxxxxxxxxxxxxxxxxx (nathans@xxxxxxxxxxxx)
Date: Sun, 17 Sep 2000 22:15:04 -0700 (PDT)
Cc: linux-xfs@xxxxxxxxxxx
Reply-to: sgi.bugs.xfs@xxxxxxxxxxxxxxxxx
Sender: owner-linux-xfs@xxxxxxxxxxx
 Submitter : dxm                      *Status : closed                      
 Assigned Engineer : nathans          *Fixed By : nathans                   
*Fixed By Domain : engr               *Closed Date : 09/17/00               
 Priority : 4                         *Modified Date : 09/17/00             
*Modified User : nathans              *Modified User Domain : engr          
*Fix Description :
From: nathan scott <nathans@xxxxxxxxxxxxxxxxxxxxxxx> (TAKE)
Date: Sep 17 2000 10:15:04PM
[pvnews version: 1.71]
----------------------------

Got the green light for this to go into beta.  Also rolled
the version number for xfs-cmds to 1.0.5 for official beta.

Modid:  2.4.0-test1-xfs:slinx:74557a
Date:  Sun Sep 17 22:09:48 PDT 2000
Workarea:  snort:/build4/nathans/base-linux-xfs
Author:  nathans

The following file(s) were checked into:
  bonnie.engr.sgi.com:/isms/slinx/2.4.0-test1-xfs

cmd/xfs/CHANGELOG - 1.5
        - document change to version number for beta.

cmd/xfs/VERSION - 1.6
        - change version number for beta.

cmd/xfs/db/init.c - 1.28
        - fix inappropriate use of usage() after library init() failure.

cmd/xfs/db/xfs_check.sh - 1.5
cmd/xfs/db/xfs_check64.sh - 1.3
        - don't allow check to run on mounted filesystems.

cmd/xfs/include/libxfs.h - 1.15
cmd/xfs/libxfs/init.c - 1.11
cmd/xfs/logprint/logprint.c - 1.47
        - add libxfs_ismounted for checking whether device is mounted.

cmd/xfs/repair/init.c - 1.13
        - don't allow repair -n to run on mounted filesystems.
Description :
both "xfs_check" and "xfs_repair -n" may be run on a mounted
filesystem and will usually produce lots of warnings about
filesystem corruption due to the inconsistent state the FS
is in.

Both tools should fail or at least warn that the FS is mounted
before proceeding. 

xfs_logprint should also warn when run on a mounted FS, but
can still be useful when mounted.

.....


==========================
ADDITIONAL INFORMATION (REASSIGN)
From: nathans@engr (BugWorks)
Date: Sep 14 2000 07:05:49PM
==========================

hi,

I have a (trivial) fix which does this:


$ logprint/xfs_logprint /dev/hda5
xfs_logprint: /dev/hda5 contains a mounted filesystem
...[carries on]...

$ sh db/xfs_check.sh /dev/hda5
xfs_check: /dev/hda5 contains a mounted filesystem

fatal error -- couldn't initialize XFS library
[exit]
$ sudo repair/xfs_repair -n /dev/hda6 
xfs_repair: /dev/hda6 contains a mounted filesystem

fatal error -- couldn't initialize XFS library
[exit]

for the folks cloning the tree - is this a beta candidate,
or shall I wait and check in the change later?

many thanks.

<Prev in Thread] Current Thread [Next in Thread>