xfs
[Top] [All Lists]

ADD 799711 - LINUX XFS reports wrong permissions.

To: nb@xxxxxxx
Subject: ADD 799711 - LINUX XFS reports wrong permissions.
From: pv@xxxxxxxxxxxxxxxxxxxxxx (cattelan@xxxxxxxxxxx)
Date: Wed, 23 Aug 2000 09:50:04 -0700 (PDT)
Cc: linux-xfs@xxxxxxxxxxx
Reply-to: sgi.bugs.xfs@xxxxxxxxxxxxxxxxx
Sender: owner-linux-xfs@xxxxxxxxxxx
 Submitter : cattelan                  Status : open                        
 Assigned Engineer : nb                Priority : 3                         
*Modified Date : 08/23/00             *Modified User : cattelan             
*Modified User Domain : thebarn.com   *Description :
nt8[5:33pm]-=>ls -l
total 121
drwxr-xrwx   16 cattelan sdivmisc    4096 Mar  6 18:37 ./
drwxrwxr-x   42 cattelan sdivmisc    4096 Apr 14 13:04 ../
drwxr-xr-x    2 cattelan sdivmisc    4096 Feb 17  1999 BT_ESCM/
drwxr-xr-x    2 cattelan sdivmisc    4096 Aug  9 17:21 
Chicane_FarFromTheMaddeni ngCrowds/
drwxr-xr-x    2 cattelan sdivmisc    4096 Feb 17  1999 
GlobalUnderground_PaulOak enfold-NewYork_d1/
drwxr-xr-x    2 cattelan sdivmisc    4096 Feb 17  1999 
GlobalUnderground_PaulOak enfold-NewYork_d2/
drwxr-xr-x    2 cattelan sdivmisc    4096 Feb 17  1999 
JerryBonham_Interpretatio nsByJerryBonham/
drwxr-xr-x    2 cattelan sdivmisc    4096 Feb 17  1999 
JerryBonham_SoundEscapes_ d1/

.....


==========================
ADDITIONAL INFORMATION (ADD)
From: russell cattelan <cattelan@xxxxxxxxxxx>
Date: Aug 23 2000 09:50:04AM
[pvnews version: 1.71]
==========================
"William L. Jones" wrote:


> open_by_handle can cause this, where you doning a xfsdump?

No, basically the only activity on the file system was serving up some
nfs traffic.

This does give me something to go on, I'll dig around and see if
anything looks suspicious.


BTW I have your latest ioctl patch in my tree,
ran fsr a few times...  seems to work just fine.
I'll commit it shortly.

>
>
> The problem in open_by_handle in xfs_ioctl.c.  It is doing a
> linvfs_set_inode_ops
> with out doing a linvfs_revalidate_core after, linvfs_set_inode_op clears
> the perm bits in the mode field.  The following patch
> will fix the current oepn_by_handle:
>
> *** xfs_ioctl.c.orig    Sat Aug 19 14:03:21 2000
> --- xfs_ioctl.c Wed Aug 23 10:01:58 2000
> ***************
> *** 481,486 ****
> --- 481,492 ----
>                   * Set xfs inode ops.
>                   */
>                  linvfs_set_inode_ops(inode);
> +
> +               /*
> +                * Fix the perm mode flags that linvfs_set_inode_ops bashes.
> +                */
> +               linvfs_revalidate_core(inode);
> +
>                  d_add(dentry, inode);
>          }
> --------------------- end -------------------------------------------------
>
> If this doesn't fix the problem then there may be some other place were
> linvfs_set_inode_ops gets called with out a linvfs_set_inode_ops
> call right after.
>
>

<Prev in Thread] Current Thread [Next in Thread>