Re: SGI XFS on ppc

[Thomas Graichen <news-innominate.list.sgi.xfs@xxxxxxxxxxxxx>]

Steve Lord <lord@xxxxxxx> wrote:
> Try changing include/linux/page_buf_trace.h to look like this:

did it and it fixed it - thanks

> As it stands it can only be included once, you are including it twice,
> once to get the event_names array and once to declare the enumerated
> type. You actually need both - you are probably getting warnings like
> this when building pagebuf:

> page_buf.c: In function `pagebuf_rele':
> page_buf.c:976: warning: passing arg 2 of `pb_trace_func' makes integer from 
> pointer without a cast

> this is because you are passing the string into pb_trace_fun rather than
> the enumerated type.

yes i did and they are gone now - thanks again - i now have it
running fine on x86 which is i think a really good start for
moving back to ppc this evening - thanks a lot again

t

> p.s. from the trace you are completing the read of the super block

yes - but this was on x86 - so it should work quite well there :-)

btw. here is the output now which looks ok (but again - only on x86
so far)

kernel: page_buf module - Copyright (C) by Silicon Graphics Inc. 2000 
kernel: pb 0xc7295ee0 [get] (hold 1 lock 0) misc 0xc15f0e20 
kernel:     address 0xc8c30f72 
kernel:     offset 0x0 size 0x200 task 0xc39bc000 
kernel:     flags: NONE LOCKABLE FORECIO 
kernel: pb 0xc7295ee0 [no_daddr] (hold 1 lock 0) misc 0xc5033600 
kernel:     address 0xc8cb6c61 
kernel:     offset 0x0 size 0x200 task 0xc39bc000 
kernel:     flags: MAPPED NONE LOCKABLE MEM_ALLOCATED FORECIO 
kernel: pb 0xc7295ee0 [ioreq] (hold 1 lock 0) misc 0x00000000 
kernel:     address 0xc8cb6c0b 
kernel:     offset 0x0 size 0x200 task 0xc39bc000 
kernel:     flags: READ MAPPED NONE LOCKABLE MEM_ALLOCATED FORECIO 
...

-- 
thomas.graichen@xxxxxxxxxxxxx
technical director                                       innominate AG
clustering & security                                networking people
tel: +49.30.308806-13 fax: -77 web: http://innominate.de pgp: /pgp/tgr