xfs
[Top] [All Lists]

Re: fsr_xfs.c patch

To: Steve Lord <lord@xxxxxxx>
Subject: Re: fsr_xfs.c patch
From: William L Jones <jones@xxxxxxxxxxxxxxxxxx>
Date: Fri, 28 Jul 2000 20:33:22 -0500 (CDT)
Cc: linux-xfs@xxxxxxxxxxx
Sender: owner-linux-xfs@xxxxxxxxxxx
>>
>> The XFS_IOC_DIOINFO ioctl does not set enough values for fsr_xfs work 
>> properly.
>> In its current state it replace good file with zero filled files.  The 
>> following
>> patch works around the problem until direct I/O works under linux.
>>
>
>
>Hmm, are you sure? I just threw this into a binary ang got all zeros after
>a defragment of the file.
>
>I would dig further but I am about to checkin a mod to 2400 files.....

Hmm,  for fsr_xfs to work it needs this mod.   With out it fsr_xfs will do a 
read
with a byte count of zero.  Since the blsz_dio and d_min variables are set to
zero.   

Try runnin with "-d" if you see the following line:

DEBUG: fsize=6870859 blsz_dio=0 d_min=0 d_max=4096 pgsz=0

then fsr will prodcue a file of all zero's.

If you  see the following:

DEBUG: fsize=6870859 blsz_dio=0 d_min=40690 d_max=40690 pgsz=40690

It should work!

d_min and blsz_dio have to be nonzero.   I verified this by printf's and  by 
looking at the
code.

blsz_dio is really nonzero after this modification.  Their are some problem
with the width size of some variables in the fsrprintf formats. Since the
compiler does not squawk about them at compile time they have gone unnoticed.

Bill Jones





<Prev in Thread] Current Thread [Next in Thread>