xfs
[Top] [All Lists]

Another bug in xfs_ioctl.c

To: linux-xfs@xxxxxxxxxxx
Subject: Another bug in xfs_ioctl.c
From: William L Jones <jones@xxxxxxxxxxxxxxxxxx>
Date: Thu, 20 Jul 2000 16:53:02 -0500 (CDT)
Sender: owner-linux-xfs@xxxxxxxxxxx

I keeped getting an EINVAL erro for XFS_IOC_RESVSP64.

This is do a difference in the way xfs_ioctl.c defines xfs_change_file_spce as:

int
xfs_change_file_space(
        bhv_desc_t      *bdp,
        int             cmd,
        xfs_flock64_t   *bf,
        off_t           offset,
        cred_t          *credp,
        int             attr_flags);


ut xfs_vnodeops.c, the owner of xfs_change_file_space, define it as  is:

int
xfs_change_file_space(
        bhv_desc_t      *bdp,
        int             cmd,
        xfs_flock64_t   *bf,
        xfs_off_t               offset,
        cred_t          *credp,
        int             attr_flags);



off_t is smaller the xfs_off_t.  The cause XFS_IOC_RESVSP64 to return EINVAL.
Changing the definition of xfs_change_file_space in xfs_ioctl.c to match that
as xfs_vnodeops.c fixes the problem.


Bill Jones

<Prev in Thread] Current Thread [Next in Thread>