xfs
[Top] [All Lists]

Re: page_buf breakage...

To: Daniel Moore <dxm@xxxxxxxxxxxxxxxxxxxxxxxx>
Subject: Re: page_buf breakage...
From: Russell Cattelan <cattelan@xxxxxxxxxxx>
Date: Wed, 12 Jul 2000 01:22:24 -0500
Cc: linux-xfs@xxxxxxxxxxx
References: <200007120550.PAA65281@clouds.melbourne.sgi.com>
Reply-to: cattelan@xxxxxxxxxxx
Sender: owner-linux-xfs@xxxxxxxxxxx
Daniel Moore wrote:

> I've finally nailed this one down...
>
> Under certain circumstances during a clean remount, the log
> recovery code clobbers a large area of disk after the end of
> the log.
>
> The reason this happens is because a particular piece of
> recovery code uses xlog_get_bp to request a big buffer, then
> uses XFS_BUF_SET_COUNT to set the pb_count_desired field
> requesting that only a portion of the buffer be written.
>
> pagebuf ignores the pb_count_desired field and writes
> pb_buffer_length bytes anyway. The XFS_BUF_SET_COUNT isn't used
> anywhere else in XFS.
>
> Is pb_count_desired meant to be supported or is it an IRIX hang
> over that needs to be removed?

Hmm... well we need to write out the correct number of bytes.
Let me look at this and see if we should change xfs or pagebuf...

Where in pagebuf is it ignoring the count field?

>
>
> If it's the latter, I'll happily remove it...
>
> -----------------------------------------------------
>  Daniel Moore                  dxm@xxxxxxx
>  R&D Software Engineer         Phone: +61-3-98348209
>  SGI Performance Tools Group   Fax:   +61-3-98132378
> -----------------------------------------------------

--
Russell Cattelan
cattelan@xxxxxxxxxxx




<Prev in Thread] Current Thread [Next in Thread>