Phil Schwan wrote:
> While hacking files from scratch, I noticed the huge number of
> dependencies that #includes don't resolve for themselves. Is there
> some reason for this, or did it just happen over time? Does anyone
> mind if I apply this patch? It doesn't fix them all, but it gets the
> ones that I've run into so far.
> \
What does this fix?
xfs_types.h should be in xfs_os_defs.h already.
Which should be included by about everything.
The rest shouldn't really matter, as long as it doesn't break either
one of the build paths.
>
> -Phil
>
> ===========================================================================
> linux/fs/xfs/xfs_attr_sf.h
> ===========================================================================
>
> --- /usr/tmp/TmpDir.6064-0/linux/fs/xfs/xfs_attr_sf.h_1.11 Thu May 18
> 14:00:40 2000
> +++ linux/fs/xfs/xfs_attr_sf.h Thu May 18 13:00:43 2000
> @@ -34,6 +34,9 @@
>
> #ident "$Revision: 1.11 $"
>
> +#include "xfs_types.h"
> +#include "xfs_dir_sf.h"
> +
> /*
> * xfs_attr_sf.h
> *
>
> ===========================================================================
> linux/fs/xfs/xfs_bmap_btree.h
> ===========================================================================
>
> --- /usr/tmp/TmpDir.6064-0/linux/fs/xfs/xfs_bmap_btree.h_1.46 Thu May 18
> 14:00:40 2000
> +++ linux/fs/xfs/xfs_bmap_btree.h Thu May 18 13:01:21 2000
> @@ -34,6 +34,7 @@
>
> #ident "$Revision: 1.46 $"
>
> +#include "xfs_types.h"
> #include "xfs_buf.h"
>
> #define XFS_BMAP_MAGIC 0x424d4150 /* 'BMAP' */
>
> ===========================================================================
> linux/fs/xfs/xfs_dinode.h
> ===========================================================================
>
> --- /usr/tmp/TmpDir.6064-0/linux/fs/xfs/xfs_dinode.h_1.55 Thu May 18
> 14:00:40 2000
> +++ linux/fs/xfs/xfs_dinode.h Thu May 18 13:00:09 2000
> @@ -36,6 +36,12 @@
>
> #ident "$Revision: 1.55 $"
>
> +#include <sys/uuid.h>
> +#include "xfs_inum.h"
> +#include "xfs_bmap_btree.h"
> +#include "xfs_attr_sf.h"
> +#include "xfs_dir2_sf.h"
> +
> struct xfs_buf;
> struct xfs_mount;
>
>
> ===========================================================================
> linux/fs/xfs/xfs_dir_sf.h
> ===========================================================================
>
> --- /usr/tmp/TmpDir.6064-0/linux/fs/xfs/xfs_dir_sf.h_1.17 Thu May 18
> 14:00:40 2000
> +++ linux/fs/xfs/xfs_dir_sf.h Thu May 18 13:01:03 2000
> @@ -34,6 +34,8 @@
>
> #ident "$Revision: 1.17 $"
>
> +#include "xfs_types.h"
> +
> /*
> * xfs_dir_sf.h
> *
>
> ===========================================================================
> linux/fs/xfs/xfs_mount.h
> ===========================================================================
>
> --- /usr/tmp/TmpDir.6064-0/linux/fs/xfs/xfs_mount.h_1.110 Thu May 18
> 14:00:40 2000
> +++ linux/fs/xfs/xfs_mount.h Thu May 18 12:58:02 2000
> @@ -34,6 +34,11 @@
>
> #ident "$Revision: 1.110 $"
>
> +#include "xfs_sb.h"
> +#include "ksys/behavior.h"
> +#include "xfs_trans.h"
> +#include "xfs_dir.h"
> +
> struct cred;
> struct mounta;
> struct vfs;
>
> ===========================================================================
> linux/fs/xfs/xfs_sb.h
> ===========================================================================
>
> --- /usr/tmp/TmpDir.6064-0/linux/fs/xfs/xfs_sb.h_1.44 Thu May 18 14:00:40
> 2000
> +++ linux/fs/xfs/xfs_sb.h Thu May 18 12:59:15 2000
> @@ -34,6 +34,10 @@
>
> #ident "$Revision: 1.44 $"
>
> +#include <sys/uuid.h>
> +#include "xfs_inum.h"
> +#include "xfs_dinode.h"
> +
> /*
> * Super block
> * Fits into a 512-byte buffer at daddr_t 0 of each allocation group.
>
> ===========================================================================
> linux/fs/xfs/xfs_trans.h
> ===========================================================================
>
> --- /usr/tmp/TmpDir.6064-0/linux/fs/xfs/xfs_trans.h_1.104 Thu May 18
> 14:00:40 2000
> +++ linux/fs/xfs/xfs_trans.h Thu May 18 12:58:43 2000
> @@ -34,6 +34,8 @@
>
> #ident "$Revision: 1.104 $"
>
> +#include "xfs_log.h"
> +
> struct xfs_buf;
> struct buftarg;
> struct xfs_efd_log_item;
|