At Thu, 13 Apr 2000 13:15:16 -0500,
Steve Lord <lord@xxxxxxx> wrote:
>
>
> > On Apr 13, cattelan@xxxxxxxxxxx wrote:
> > > First it would be best not to include linux/fs.h in any file
> > > not in the fs/xfs/linux directory. It will cause headaches.
> > >
> > > If fact that linux/xfs_sema.h shouldn't be there either.
> > >
> > > If the file is general enough say types.h it can go
> > > in xfs_os_defs.h; I doesn't really hurt if some
> > > *.c files include some header files they don't need.
> > > As long as it doesn't create conflicts.
> > >
Yes I know... it's on my list of things to fix.
not that high a priority right now.
It's not a huge deal right right but as long a
Phil is asking about things; lets try and keep
things clean rather than create more stuff we
have to go back and fix up.
>
>
> Have you run cscope recently:
>
> Files #including this file: xfs_sema.h
>
> File Line
> 1 fs/xfs/xfsquotasstubs.c 84 #include <linux/xfs_sema.h>
> 2 fs/xfs/xfs_bmap.c 40 #include <linux/xfs_sema.h>
> 3 fs/xfs/xfs_buf.h 48 #include <linux/xfs_sema.h>
> 4 fs/xfs/xfs_buf.h 289 #include <linux/xfs_sema.h>
> 5 fs/xfs/xfs_log_print.c 51 #include <linux/xfs_sema.h>
> 7 fs/xfs/xfs_grio.c 41 #include <linux/xfs_sema.h>
> 8 fs/xfs/xfs_mount.c 51 #include <linux/xfs_sema.h>
> 9 xfs/linux/xfs_vnode.c 47 #include <linux/xfs_sema.h>
> 1 pseudo-inc/sys/sema_priva 50 #include <linux/xfs_sema.h>
> 2 pseudo-inc/ksys/behavior. 150 #include <linux/xfs_sema.h>
> 3 fs/xfs/xfs_dfrag.c 39 #include <linux/xfs_sema.h>
> 4 xfs/linux/xfs_random.c 155 #include <linux/xfs_sema.h>
> 5 fs/xfs/xfs_iocore.c 62 #include <linux/xfs_sema.h>
> 6 fs/xfs/xfs_vfsops.c 70 #include <linux/xfs_sema.h>
> 7 pseudo-inc/sys/vfs.h 75 #include <linux/xfs_sema.h>
> 8 pseudo-inc/ksys/kqueue.h 57 #include <linux/xfs_sema.h>
> 9 xfs/linux/xfs_fs_bio.c 47 #include <linux/xfs_sema.h>
> 1 fs/xfs/xfs_itable.c 41 #include <linux/xfs_sema.h>
> 2 fs/xfs/xfs_log_recover.c 46 #include <linux/xfs_sema.h>
> 3 fs/xfs/xfs_vnodeops.c 73 #include <linux/xfs_sema.h>
> 4 pseudo-inc/sys/vnode.h 68 #include <linux/xfs_sema.h>
> 5 fs/xfs/xfs_rw.c 54 #include <linux/xfs_sema.h>
> 6 pseudo-inc/sys/buf.h 63 #include <linux/xfs_sema.h>
> 7 fs/xfs/xfs_log.c 64 #include <linux/xfs_sema.h>
> 8 xfs/linux/xfs_uuid.c 73 #include <linux/xfs_sema.h>
> 9 fs/xfs/xfs_fsops.c 41 #include <linux/xfs_sema.h>
> 1 fs/xfs/xfs_macros.c 43 #include <linux/xfs_sema.h>
>
> And:
>
> Files #including this file: linux/fs.h
> 4 fs/xfs/xfs_vfsops.c 41 #include <linux/fs.h>
>
> And pseudo-inc/sys/capability.h (included by a number of files) includes
>
> #include <linux/capability.h>
> #include <linux/sched.h>
>
> and linux/capability.h includes fs.h
>
>
> Changing one occurrence is not going to make a difference at the moment.
>
> Steve
|