xfs-masters
[Top] [All Lists]

Re: [PATCH 05/13] XFS: Fix lock ASSERT on UP

To: Andi Kleen <andi@xxxxxxxxxxxxxx>
Subject: Re: [PATCH 05/13] XFS: Fix lock ASSERT on UP
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 30 Mar 2012 15:13:48 +1100
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, akpm@xxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Andi Kleen <ak@xxxxxxxxxxxxxxx>, xfs-masters@xxxxxxxxxxx
In-reply-to: <20120329235201.GF17822@xxxxxxxxxxxxxxxxxx>
References: <1332895637-32572-1-git-send-email-andi@xxxxxxxxxxxxxx> <1332895637-32572-6-git-send-email-andi@xxxxxxxxxxxxxx> <20120329232114.GA26342@xxxxxxxxxxxxx> <20120329235201.GF17822@xxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Mar 30, 2012 at 01:52:01AM +0200, Andi Kleen wrote:
> On Thu, Mar 29, 2012 at 07:21:14PM -0400, Christoph Hellwig wrote:
> > On Tue, Mar 27, 2012 at 05:47:09PM -0700, Andi Kleen wrote:
> > > From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> > > 
> > > ASSERT(!spin_is_locked()) doesn't work on UP builds. Replace with a 
> > > standard
> > > lockdep_assert_held()
> > 
> > The "standard" is assert_spin_locked() - which not only is much cheaper
> > but also has the advantage of working in non-lockdep builds.
> 
> But then you have it unconditional, not just on debug builds.

And the problem with that is what? There is so little overhead to the
check it doesn't matter that it is enabled in production kernels...

Cheers,

Dave.

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>