xfs-masters
[Top] [All Lists]

Re: [PATCH 05/13] XFS: Fix lock ASSERT on UP

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 05/13] XFS: Fix lock ASSERT on UP
From: Andi Kleen <andi@xxxxxxxxxxxxxx>
Date: Fri, 30 Mar 2012 01:52:01 +0200
Cc: Andi Kleen <andi@xxxxxxxxxxxxxx>, akpm@xxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Andi Kleen <ak@xxxxxxxxxxxxxxx>, xfs-masters@xxxxxxxxxxx
In-reply-to: <20120329232114.GA26342@xxxxxxxxxxxxx>
References: <1332895637-32572-1-git-send-email-andi@xxxxxxxxxxxxxx> <1332895637-32572-6-git-send-email-andi@xxxxxxxxxxxxxx> <20120329232114.GA26342@xxxxxxxxxxxxx>
User-agent: Mutt/1.4.2.2i
On Thu, Mar 29, 2012 at 07:21:14PM -0400, Christoph Hellwig wrote:
> On Tue, Mar 27, 2012 at 05:47:09PM -0700, Andi Kleen wrote:
> > From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> > 
> > ASSERT(!spin_is_locked()) doesn't work on UP builds. Replace with a standard
> > lockdep_assert_held()
> 
> The "standard" is assert_spin_locked() - which not only is much cheaper
> but also has the advantage of working in non-lockdep builds.

But then you have it unconditional, not just on debug builds.

-Andi
-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.

<Prev in Thread] Current Thread [Next in Thread>