| To: | Andi Kleen <andi@xxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 05/13] XFS: Fix lock ASSERT on UP |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Thu, 29 Mar 2012 19:21:14 -0400 |
| Cc: | akpm@xxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Andi Kleen <ak@xxxxxxxxxxxxxxx>, xfs-masters@xxxxxxxxxxx |
| In-reply-to: | <1332895637-32572-6-git-send-email-andi@xxxxxxxxxxxxxx> |
| References: | <1332895637-32572-1-git-send-email-andi@xxxxxxxxxxxxxx> <1332895637-32572-6-git-send-email-andi@xxxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Tue, Mar 27, 2012 at 05:47:09PM -0700, Andi Kleen wrote: > From: Andi Kleen <ak@xxxxxxxxxxxxxxx> > > ASSERT(!spin_is_locked()) doesn't work on UP builds. Replace with a standard > lockdep_assert_held() The "standard" is assert_spin_locked() - which not only is much cheaper but also has the advantage of working in non-lockdep builds. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Hi, Shanghai Toys Imp.,Exp.,Co.,Ltd,China |
|---|---|
| Next by Date: | Re: [PATCH 05/13] XFS: Fix lock ASSERT on UP, Andi Kleen |
| Previous by Thread: | [PATCH 05/13] XFS: Fix lock ASSERT on UP, Andi Kleen |
| Next by Thread: | Re: [PATCH 05/13] XFS: Fix lock ASSERT on UP, Andi Kleen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |