xfs-masters
[Top] [All Lists]

[PATCH] Fix xfs build error on ia64 (mismatch section for xfs_qm_exit())

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: [PATCH] Fix xfs build error on ia64 (mismatch section for xfs_qm_exit())
From: "Luck, Tony" <tony.luck@xxxxxxxxx>
Date: Mon, 26 Mar 2012 09:43:06 -0700
Cc: Ben Myers <bpm@xxxxxxx>, Alex Elder <elder@xxxxxxxxxx>, xfs-masters@xxxxxxxxxxx, xfs@xxxxxxxxxxx
ia64 deletes __exit section during the final link stage of vmlinux.
This means that code should not call __exit functions in modules
that can be built in to the kernel.

Building with CONFIG_DEBUG_SECTION_MISMATCH=y we see these build messages:

WARNING: vmlinux.o(.init.text+0x22462): Section mismatch in reference from the 
function init_xfs_fs() to the function .exit.text:xfs_qm_exit()
The function __init init_xfs_fs() references
a function __exit xfs_qm_exit().
This is often seen when error handling in the init function
uses functionality in the exit path.
The fix is often to remove the __exit annotation of
xfs_qm_exit() so it may be used outside an exit section.

...

`xfs_qm_exit' referenced in section `.init.text' of fs/built-in.o: defined in 
discarded section `.exit.text' of fs/built-in.o
make: *** [.tmp_vmlinux1] Error 1

Introduced in commit a05931ceb0160deadbd7798d60d01b17f2d81b09
    xfs: remove the global xfs_Gqm structure

Signed-off-by: Tony Luck <tony.luck@xxxxxxxxx>

---

diff --git a/fs/xfs/xfs_dquot.c b/fs/xfs/xfs_dquot.c
index 4be16a0..1155208 100644
--- a/fs/xfs/xfs_dquot.c
+++ b/fs/xfs/xfs_dquot.c
@@ -1065,7 +1065,7 @@ out:
        return -ENOMEM;
 }
 
-void __exit
+void
 xfs_qm_exit(void)
 {
        kmem_zone_destroy(xfs_qm_dqtrxzone);

<Prev in Thread] Current Thread [Next in Thread>