| To: | Dan Carpenter <dan.carpenter@xxxxxxxxxx>, santosh nayak <santoshprasadnayak@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs: Use memset to initialize structure member. |
| From: | Ben Myers <bpm@xxxxxxx> |
| Date: | Fri, 24 Feb 2012 10:05:05 -0600 |
| Cc: | elder@xxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, xfs-masters@xxxxxxxxxxx |
| In-reply-to: | <20120224075354.GA3649@mwanda> |
| References: | <1330067322-17011-1-git-send-email-santoshprasadnayak@xxxxxxxxx> <20120224075354.GA3649@mwanda> |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
Santosh,
On Fri, Feb 24, 2012 at 10:53:54AM +0300, Dan Carpenter wrote:
> On Fri, Feb 24, 2012 at 12:38:42PM +0530, santosh nayak wrote:
> > From: Santosh Nayak <santoshprasadnayak@xxxxxxxxx>
> >
> > Sparse is giving following warning:
> > fs/xfs/xfs_bmap.c:4826:41: warning: Using plain integer as NULL pointer.
> >
>
> You could just do:
> struct xfs_bmalloca bma = {};
This aggregate initializer seems cleaner than memset. Do you
mind resending the patch with Dan's suggestion?
Thanks for your contribution. ;)
-Ben
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [no subject], Ben Myers |
|---|---|
| Next by Date: | [Bug 916] xfs_log_force blocked, bugzilla-daemon |
| Previous by Thread: | Re: [PATCH] xfs: Use memset to initialize structure member., Dan Carpenter |
| Next by Thread: | [no subject], Ben Myers |
| Indexes: | [Date] [Thread] [Top] [All Lists] |