xfs-masters
[Top] [All Lists]

Re: Build regressions/improvements in v3.0-rc5 (xfs on cris)

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: Build regressions/improvements in v3.0-rc5 (xfs on cris)
From: Américo Wang <xiyou.wangcong@xxxxxxxxx>
Date: Thu, 30 Jun 2011 16:34:07 +0800
Cc: Randy Dunlap <rdunlap@xxxxxxxxxxxx>, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>, xfs-masters@xxxxxxxxxxx, Linux Kernel Development <linux-kernel@xxxxxxxxxxxxxxx>, linux-cris-kernel@xxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=zGMbSKLK7VftAe+rPK/6uTaMP1wTWOxjXx1EYetCCOo=; b=KtBAr7iAuW00K54V0ZoQKPPKyaGHxIS76stvI55ZcsZqn2kbGuH3pzEN3TMSh5t6Oi pmEjYuwh0Fp1Rd/MpUm9PcXWNb6f9DzsCPx+uG2onAmbbRNZlUDEMORzlXUUdqJ751Hi KVWkq4tZaAoUJ98CoEeiyX3S2whMQTjyUcCfE=
In-reply-to: <20110629212420.GA9822@xxxxxxxxxxxxx>
References: <alpine.DEB.2.00.1106291011400.10665@xxxxxxxxxxxx> <20110629142106.447393a5.rdunlap@xxxxxxxxxxxx> <20110629212420.GA9822@xxxxxxxxxxxxx>
On Thu, Jun 30, 2011 at 5:24 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> On Wed, Jun 29, 2011 at 02:21:06PM -0700, Randy Dunlap wrote:
>> Looks like arch/cris does not support atomic64_t.  (?)
>>
>> Should we prevent xfs from being built on arch/cris?
>
> Or nuke cris until it's able to at least include an asm-generic header?
>

Not that simple. Take a look at lib/atomic64_test.c, it said:

#if defined(CONFIG_X86) || defined(CONFIG_MIPS) || defined(CONFIG_PPC) || \
    defined(CONFIG_S390) || defined(_ASM_GENERIC_ATOMIC64_H) ||
defined(CONFIG_ARM)
...
#else
#warning Please implement atomic64_dec_if_positive for your
architecture, and add it to the IF above
#endif

So cris at least needs to implement atomic64_dec_if_positive()...

<Prev in Thread] Current Thread [Next in Thread>